chromeos/network/onc/onc_merger.cc - Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromeos/network/onc/onc_merger.cc

Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value> (Closed)

Patch Set: Comment Updates Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chromeos/network/onc/onc_merger.cc

diff --git a/chromeos/network/onc/onc_merger.cc b/chromeos/network/onc/onc_merger.cc

index df8fd5bd52e65f9be47e7c8cec8a62682455f9c1..41c6b5807ee89e13a9cc7b8a3169451ec6de8bec 100644

--- a/chromeos/network/onc/onc_merger.cc

+++ b/chromeos/network/onc/onc_merger.cc

@@ -56,7 +56,7 @@ void MarkRecommendedFieldnames(const base::DictionaryValue& policy,

for (base::ListValue::const_iterator it = recommended_value->begin();

it != recommended_value->end(); ++it) {

std::string entry;

- if ((*it)->GetAsString(&entry))

+ if (it->GetAsString(&entry))

result->SetBooleanWithoutPathExpansion(entry, true);

}