Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(800)

Unified Diff: chromeos/network/onc/onc_translator_shill_to_onc.cc

Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value> (Closed)
Patch Set: Comment Updates Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromeos/network/onc/onc_translator_shill_to_onc.cc
diff --git a/chromeos/network/onc/onc_translator_shill_to_onc.cc b/chromeos/network/onc/onc_translator_shill_to_onc.cc
index ce403666456eb6d7667b58ac74806aa2528007cb..4d8f088f1ad8a49bcfed3e8b5450b237ccddfaa2 100644
--- a/chromeos/network/onc/onc_translator_shill_to_onc.cc
+++ b/chromeos/network/onc/onc_translator_shill_to_onc.cc
@@ -683,7 +683,7 @@ void ShillToONCTranslator::TranslateAndAddListOfObjects(
for (base::ListValue::const_iterator it = list.begin(); it != list.end();
++it) {
const base::DictionaryValue* shill_value = NULL;
- if (!(*it)->GetAsDictionary(&shill_value))
+ if (!it->GetAsDictionary(&shill_value))
continue;
ShillToONCTranslator nested_translator(
*shill_value, onc_source_,

Powered by Google App Engine
This is Rietveld 408576698