Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2184)

Unified Diff: chrome/test/chromedriver/performance_logger.cc

Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value> (Closed)
Patch Set: Comment Updates Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/chromedriver/performance_logger.cc
diff --git a/chrome/test/chromedriver/performance_logger.cc b/chrome/test/chromedriver/performance_logger.cc
index 5887650e1ae74b801fceddb62a3ac224e9fa09db..64c0ab12d80264791ab1ef83b04f2642fe0bfe2f 100644
--- a/chrome/test/chromedriver/performance_logger.cc
+++ b/chrome/test/chromedriver/performance_logger.cc
@@ -190,8 +190,8 @@ Status PerformanceLogger::HandleTraceEvents(
"received DevTools trace data in unexpected format");
}
for (const auto& trace : *traces) {
- base::DictionaryValue* event_dict;
- if (!trace->GetAsDictionary(&event_dict))
+ const base::DictionaryValue* event_dict;
+ if (!trace.GetAsDictionary(&event_dict))
return Status(kUnknownError, "trace event must be a dictionary");
AddLogEntry(client->GetId(), "Tracing.dataCollected", *event_dict);
}

Powered by Google App Engine
This is Rietveld 408576698