Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Unified Diff: chrome/test/chromedriver/logging.cc

Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value> (Closed)
Patch Set: Comment Updates Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/chromedriver/logging.cc
diff --git a/chrome/test/chromedriver/logging.cc b/chrome/test/chromedriver/logging.cc
index eacb53fa094fa6c968b30c340c4bced8075be3f7..101d47e9e1c14dea377125252970cbec8354b878 100644
--- a/chrome/test/chromedriver/logging.cc
+++ b/chrome/test/chromedriver/logging.cc
@@ -170,8 +170,8 @@ bool GetFirstErrorMessageFromList(const base::ListValue* list,
for (base::ListValue::const_iterator it = list->begin();
it != list->end();
++it) {
- base::DictionaryValue* log_entry = NULL;
- (*it)->GetAsDictionary(&log_entry);
+ const base::DictionaryValue* log_entry = NULL;
+ it->GetAsDictionary(&log_entry);
if (log_entry != NULL) {
std::string level;
if (log_entry->GetString("level", &level))

Powered by Google App Engine
This is Rietveld 408576698