Disable unit tests for Window Manager Client in external window mode

Disable unit tests for Window Manager Client in external window mode

After [1], no default display is created at the startup of the window
server, making the following mus_ws_unitests hang:

  WindowServerTest.OnWindowHierarchyChangedIncludesTransientParent
  WindowServerTest.RootWindow
  WindowServerTest.Embed
  WindowServerTest.EmbeddedDoesntSeeChild
  WindowServerTest.SetBounds
  WindowServerTest.SetBoundsSecurity
  WindowServerTest.DestroySecurity
  WindowServerTest.MultiRoots
  WindowServerTest.Reorder
  WindowServerTest.Visible
  WindowServerTest.EmbedFailsWithChildren
  WindowServerTest.WindowServerDestroyedAfterRootObserver
  WindowServerTest.ClientAreaChanged
  WindowServerTest.EstablishConnectionViaFactory

The issue is that WindowServerTestBase::SetUp is designed to wait
until OnWmNewDisplay is called to be sure that a display (and root)
is available, which never happens in external window mode.

The above tests check WindowManagerClient and this class is not needed
in external mode since the host system is always the window manager.
Hence this CL disables these tests in external window mode, making
mus_ws_unitests pass again on the corresponding platforms.

[1] https://codereview.chromium.org/2697693002/

BUG=666958
Review-Url: https://codereview.chromium.org/2740123002
Cr-Commit-Position: refs/heads/master@{#455902}
Committed: https://chromium.googlesource.com/chromium/src/+/7dac3c6c0969d2c407213199691841e29baf3979

[fwang, 2017-03-09 15:13:54]

Description was changed from

==========
Disable unit tests for Window Manager Client in external window mode

After [1], no default display is created at the startup of the window
server, making the following mus_ws_unitests hang:

  WindowServerTest.OnWindowHierarchyChangedIncludesTransientParent
  WindowServerTest.RootWindow
  WindowServerTest.Embed
  WindowServerTest.EmbeddedDoesntSeeChild
  WindowServerTest.SetBounds
  WindowServerTest.SetBoundsSecurity
  WindowServerTest.DestroySecurity
  WindowServerTest.MultiRoots
  WindowServerTest.Reorder
  WindowServerTest.Visible
  WindowServerTest.EmbedFailsWithChildren
  WindowServerTest.WindowServerDestroyedAfterRootObserver
  WindowServerTest.ClientAreaChanged
  WindowServerTest.EstablishConnectionViaFactory

The issue is that WindowServerTestBase::SetUp is designed to wait
until OnWmNewDisplay is called to be sure that a display (and root)
is available, which never happens in external window mode.

The above tests check WindowManagerClient and this class is not needed
in external mode since the host system is always the window manager.
Hence this CL disables these tests in external window mode, making
mus_ws_unitests pass again on the corresponding platforms.

[1] https://codereview.chromium.org/2697693002/

BUG=666958
==========

to

==========
Disable unit tests for Window Manager Client in external window mode

After [1], no default display is created at the startup of the window
server, making the following mus_ws_unitests hang:

  WindowServerTest.OnWindowHierarchyChangedIncludesTransientParent
  WindowServerTest.RootWindow
  WindowServerTest.Embed
  WindowServerTest.EmbeddedDoesntSeeChild
  WindowServerTest.SetBounds
  WindowServerTest.SetBoundsSecurity
  WindowServerTest.DestroySecurity
  WindowServerTest.MultiRoots
  WindowServerTest.Reorder
  WindowServerTest.Visible
  WindowServerTest.EmbedFailsWithChildren
  WindowServerTest.WindowServerDestroyedAfterRootObserver
  WindowServerTest.ClientAreaChanged
  WindowServerTest.EstablishConnectionViaFactory

The issue is that WindowServerTestBase::SetUp is designed to wait
until OnWmNewDisplay is called to be sure that a display (and root)
is available, which never happens in external window mode.

The above tests check WindowManagerClient and this class is not needed
in external mode since the host system is always the window manager.
Hence this CL disables these tests in external window mode, making
mus_ws_unitests pass again on the corresponding platforms.

[1] https://codereview.chromium.org/2697693002/

BUG=666958
==========

[kylechar, 2017-03-09 15:26:28]

https://codereview.chromium.org/2740123002/diff/1/services/ui/ws/BUILD.gn
File services/ui/ws/BUILD.gn (right):

https://codereview.chromium.org/2740123002/diff/1/services/ui/ws/BUILD.gn#new...
services/ui/ws/BUILD.gn:176: if (!use_ozone || is_chromeos) {
Add a variable that you can reuse for this.

is_external_mode = use_ozone && !is_chromeos

[fwang, 2017-03-09 15:56:48]

The CQ bit was checked by fwang@igalia.com to run a CQ dry run

[fwang, 2017-03-09 15:57:01]

fwang@igalia.com changed reviewers:
+ msw@chromium.org

[fwang, 2017-03-09 15:57:02]

PTAL

[commit-bot: I haz the power, 2017-03-09 15:57:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fwang, 2017-03-09 16:05:40]

The CQ bit was unchecked by fwang@igalia.com

[fwang, 2017-03-09 16:07:20]

The CQ bit was checked by fwang@igalia.com to run a CQ dry run

[commit-bot: I haz the power, 2017-03-09 16:08:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[msw, 2017-03-09 16:51:23]

lgtm with a nit

https://codereview.chromium.org/2740123002/diff/40001/services/ui/ws/BUILD.gn
File services/ui/ws/BUILD.gn (right):

https://codereview.chromium.org/2740123002/diff/40001/services/ui/ws/BUILD.gn...
services/ui/ws/BUILD.gn:12: is_external_mode = use_ozone && !is_chromeos
nit: add a comment explaining what this is, eg. "The window server's external
window mode creates individual top-level native {x11, wayland, mir, ...}
windows, ie. not children of a Chrome OS window manager's root window." Feel
free to cleanup that comment, I had never heard of 'external mode' before
reading through the associated bug.

[commit-bot: I haz the power, 2017-03-09 17:21:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-09 17:21:15]

Dry run: This issue passed the CQ dry run.

[fwang, 2017-03-09 21:52:49]

https://codereview.chromium.org/2740123002/diff/40001/services/ui/ws/BUILD.gn
File services/ui/ws/BUILD.gn (right):

https://codereview.chromium.org/2740123002/diff/40001/services/ui/ws/BUILD.gn...
services/ui/ws/BUILD.gn:12: is_external_mode = use_ozone && !is_chromeos
On 2017/03/09 16:51:22, msw wrote:
> nit: add a comment explaining what this is, eg. "The window server's external
> window mode creates individual top-level native {x11, wayland, mir, ...}
> windows, ie. not children of a Chrome OS window manager's root window." Feel
> free to cleanup that comment, I had never heard of 'external mode' before
> reading through the associated bug.

Done.

[fwang, 2017-03-09 21:53:24]

The CQ bit was checked by fwang@igalia.com

[fwang, 2017-03-09 21:53:24]

The patchset sent to the CQ was uploaded after l-g-t-m from msw@chromium.org
Link to the patchset: https://codereview.chromium.org/2740123002/#ps60001
(title: "Add a comment about external mode.")

[commit-bot: I haz the power, 2017-03-09 21:53:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-09 23:45:44]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1489096404425200,
"parent_rev": "e5e975b33027b19dc96bfbab42f09c9c7839c63e", "commit_rev":
"7dac3c6c0969d2c407213199691841e29baf3979"}

[commit-bot: I haz the power, 2017-03-09 23:46:24]

Description was changed from

==========
Disable unit tests for Window Manager Client in external window mode

After [1], no default display is created at the startup of the window
server, making the following mus_ws_unitests hang:

  WindowServerTest.OnWindowHierarchyChangedIncludesTransientParent
  WindowServerTest.RootWindow
  WindowServerTest.Embed
  WindowServerTest.EmbeddedDoesntSeeChild
  WindowServerTest.SetBounds
  WindowServerTest.SetBoundsSecurity
  WindowServerTest.DestroySecurity
  WindowServerTest.MultiRoots
  WindowServerTest.Reorder
  WindowServerTest.Visible
  WindowServerTest.EmbedFailsWithChildren
  WindowServerTest.WindowServerDestroyedAfterRootObserver
  WindowServerTest.ClientAreaChanged
  WindowServerTest.EstablishConnectionViaFactory

The issue is that WindowServerTestBase::SetUp is designed to wait
until OnWmNewDisplay is called to be sure that a display (and root)
is available, which never happens in external window mode.

The above tests check WindowManagerClient and this class is not needed
in external mode since the host system is always the window manager.
Hence this CL disables these tests in external window mode, making
mus_ws_unitests pass again on the corresponding platforms.

[1] https://codereview.chromium.org/2697693002/

BUG=666958
==========

to

==========
Disable unit tests for Window Manager Client in external window mode

After [1], no default display is created at the startup of the window
server, making the following mus_ws_unitests hang:

  WindowServerTest.OnWindowHierarchyChangedIncludesTransientParent
  WindowServerTest.RootWindow
  WindowServerTest.Embed
  WindowServerTest.EmbeddedDoesntSeeChild
  WindowServerTest.SetBounds
  WindowServerTest.SetBoundsSecurity
  WindowServerTest.DestroySecurity
  WindowServerTest.MultiRoots
  WindowServerTest.Reorder
  WindowServerTest.Visible
  WindowServerTest.EmbedFailsWithChildren
  WindowServerTest.WindowServerDestroyedAfterRootObserver
  WindowServerTest.ClientAreaChanged
  WindowServerTest.EstablishConnectionViaFactory

The issue is that WindowServerTestBase::SetUp is designed to wait
until OnWmNewDisplay is called to be sure that a display (and root)
is available, which never happens in external window mode.

The above tests check WindowManagerClient and this class is not needed
in external mode since the host system is always the window manager.
Hence this CL disables these tests in external window mode, making
mus_ws_unitests pass again on the corresponding platforms.

[1] https://codereview.chromium.org/2697693002/

BUG=666958

Review-Url: https://codereview.chromium.org/2740123002
Cr-Commit-Position: refs/heads/master@{#455902}
Committed:
https://chromium.googlesource.com/chromium/src/+/7dac3c6c0969d2c4072131996918...
==========

[commit-bot: I haz the power, 2017-03-09 23:46:25]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/7dac3c6c0969d2c4072131996918...