Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Issue 2740113002: 🏡 Deduplicate no content string. (Closed)

Created:
3 years, 9 months ago by PEConn
Modified:
3 years, 9 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews, srahim+watch_chromium.org, noyau+watch_chromium.org, ntp-dev+reviews_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

🏡 Deduplicate no content string. Also, change some apostrophes. BUG=699932 Review-Url: https://codereview.chromium.org/2740113002 Cr-Commit-Position: refs/heads/master@{#456033} Committed: https://chromium.googlesource.com/chromium/src/+/9cdcb2efd7fab626616bdf69b045798a18ca2a73

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -9 lines) Patch
M chrome/android/java/res/layout/new_tab_page_all_dismissed.xml View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/StatusItem.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/strings/android_chrome_strings.grd View 4 chunks +3 lines, -6 lines 0 comments Download
M components/ntp_snippets_strings.grdp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
PEConn
PTAL
3 years, 9 months ago (2017-03-09 11:50:31 UTC) #2
Bernhard Bauer
LGTM, thanks.
3 years, 9 months ago (2017-03-09 12:00:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2740113002/1
3 years, 9 months ago (2017-03-10 09:37:17 UTC) #5
commit-bot: I haz the power
3 years, 9 months ago (2017-03-10 10:11:02 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9cdcb2efd7fab626616bdf69b045...

Powered by Google App Engine
This is Rietveld 408576698