Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Issue 2740103004: Fix wrong paint invalidation container for column spanners (Closed)

Created:
3 years, 9 months ago by Xianzhu
Modified:
3 years, 9 months ago
Reviewers:
Xianzhu
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, dshwang, jchaffraix+rendering, blink-reviews-paint_chromium.org, blink-reviews
Target Ref:
refs/pending/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

Fix wrong paint invalidation container for column spanners If a column spanner is under a composited column content, it doesn't paint onto this composited column content because it belongs to the column container in paint order. This regressed since https://codereview.chromium.org/2615203002. BUG=698216 TBR=wangxianzhu@chromium.org NOTRY=true NOPRESUBMIT=true TEST=paint/invalidation/compositing/column-span-under-composited-column-child.html CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2736373003 Cr-Original-Commit-Position: refs/heads/master@{#455841} Review-Url: https://codereview.chromium.org/2740103004 Cr-Commit-Position: refs/branch-heads/3029@{#113} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/52520d1f00753da9adafc914b4856ed9052e3678

Patch Set 1 #

Messages

Total messages: 5 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2740103004/1
3 years, 9 months ago (2017-03-10 17:45:51 UTC) #2
commit-bot: I haz the power
3 years, 9 months ago (2017-03-10 17:48:15 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/52520d1f00753da9adafc914b485...

Powered by Google App Engine
This is Rietveld 408576698