Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 2736373003: Fix wrong paint invalidation container for column spanners (Closed)

Created:
3 years, 9 months ago by Xianzhu
Modified:
3 years, 9 months ago
Reviewers:
pdr., chrishtr
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, dshwang, jchaffraix+rendering, blink-reviews-paint_chromium.org, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix wrong paint invalidation container for column spanners If a column spanner is under a composited column content, it doesn't paint onto this composited column content because it belongs to the column container in paint order. This regressed since https://codereview.chromium.org/2615203002. BUG=698216 TEST=paint/invalidation/compositing/column-span-under-composited-column-child.html CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2736373003 Cr-Commit-Position: refs/heads/master@{#455841} Committed: https://chromium.googlesource.com/chromium/src/+/d0a53bebc4896e68c81ba549a2c01674a3d6621f

Patch Set 1 #

Messages

Total messages: 9 (5 generated)
Xianzhu
We need to land this in m57 before it becomes stable.
3 years, 9 months ago (2017-03-09 17:37:23 UTC) #3
pdr.
On 2017/03/09 at 17:37:23, wangxianzhu wrote: > We need to land this in m57 before ...
3 years, 9 months ago (2017-03-09 17:41:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2736373003/1
3 years, 9 months ago (2017-03-09 17:58:46 UTC) #6
commit-bot: I haz the power
3 years, 9 months ago (2017-03-09 20:03:18 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d0a53bebc4896e68c81ba549a2c0...

Powered by Google App Engine
This is Rietveld 408576698