Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(506)

Issue 2740103003: [compiler] Log message when function is already in optimization queue. (Closed)

Created:
3 years, 9 months ago by Benedikt Meurer
Modified:
3 years, 9 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[compiler] Log message when function is already in optimization queue. Add log message when RuntimeProfiler checks whether to optimize a function, but that function is already in the optimization queue (with --trace-opt-verbose). R=yangguo@chromium.org Review-Url: https://codereview.chromium.org/2740103003 Cr-Commit-Position: refs/heads/master@{#43711} Committed: https://chromium.googlesource.com/v8/v8/+/f66d934bae7ce835a574b6d2c4fa46b3da6743f0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -3 lines) Patch
M src/runtime-profiler.cc View 3 chunks +24 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
Benedikt Meurer
3 years, 9 months ago (2017-03-10 05:07:34 UTC) #1
Yang
On 2017/03/10 05:07:34, Benedikt Meurer wrote: lgtm
3 years, 9 months ago (2017-03-10 05:24:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2740103003/1
3 years, 9 months ago (2017-03-10 05:24:56 UTC) #7
commit-bot: I haz the power
3 years, 9 months ago (2017-03-10 05:36:07 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/f66d934bae7ce835a574b6d2c4fa46b3da6...

Powered by Google App Engine
This is Rietveld 408576698