Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Unified Diff: src/runtime-profiler.cc

Issue 2740103003: [compiler] Log message when function is already in optimization queue. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/runtime-profiler.cc
diff --git a/src/runtime-profiler.cc b/src/runtime-profiler.cc
index 6f9f44ee2ad4c83de28a778609e9c6a7b8fd5b17..917771bdc5d57c069f3ead7170f7a2303a4abed1 100644
--- a/src/runtime-profiler.cc
+++ b/src/runtime-profiler.cc
@@ -216,7 +216,14 @@ void RuntimeProfiler::MaybeOptimizeFullCodegen(JSFunction* function,
SharedFunctionInfo* shared = function->shared();
Code* shared_code = shared->code();
if (shared_code->kind() != Code::FUNCTION) return;
- if (function->IsInOptimizationQueue()) return;
+ if (function->IsInOptimizationQueue()) {
+ if (FLAG_trace_opt_verbose) {
+ PrintF("[function ");
+ function->PrintName();
+ PrintF(" is already in optimization queue]\n");
+ }
+ return;
+ }
if (FLAG_always_osr) {
AttemptOnStackReplacement(frame, AbstractCode::kMaxLoopNestingMarker);
@@ -308,7 +315,14 @@ void RuntimeProfiler::MaybeOptimizeFullCodegen(JSFunction* function,
void RuntimeProfiler::MaybeBaselineIgnition(JSFunction* function,
JavaScriptFrame* frame) {
- if (function->IsInOptimizationQueue()) return;
+ if (function->IsInOptimizationQueue()) {
+ if (FLAG_trace_opt_verbose) {
+ PrintF("[function ");
+ function->PrintName();
+ PrintF(" is already in optimization queue]\n");
+ }
+ return;
+ }
if (FLAG_always_osr) {
AttemptOnStackReplacement(frame, AbstractCode::kMaxLoopNestingMarker);
@@ -334,7 +348,14 @@ void RuntimeProfiler::MaybeBaselineIgnition(JSFunction* function,
void RuntimeProfiler::MaybeOptimizeIgnition(JSFunction* function,
JavaScriptFrame* frame) {
- if (function->IsInOptimizationQueue()) return;
+ if (function->IsInOptimizationQueue()) {
+ if (FLAG_trace_opt_verbose) {
+ PrintF("[function ");
+ function->PrintName();
+ PrintF(" is already in optimization queue]\n");
+ }
+ return;
+ }
if (FLAG_always_osr) {
AttemptOnStackReplacement(frame, AbstractCode::kMaxLoopNestingMarker);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698