Check StaticBitmapImage has changed from Mailbox to Skia in OffscreenCanvas commit

Check StaticBitmapImage has changed from Mailbox to Skia in OffscreenCanvas commit

This is a follow-up CL of https://codereview.chromium.org/2632593003/.
This will make "WebRtcCaptureFromElementBrowserTest.VerifyCanvasCaptureOffscreenCanvasCommitFrames" not hit UNREACHED when it is enabled.

BUG=693229
Review-Url: https://codereview.chromium.org/2740003004
Cr-Commit-Position: refs/heads/master@{#456402}
Committed: https://chromium.googlesource.com/chromium/src/+/08583e375717564923404ed4b6fd6660ce259a97

[xlai (Olivia), 2017-03-09 22:32:56]

The CQ bit was checked by xlai@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-09 22:33:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-10 00:09:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-10 00:09:58]

Dry run: This issue passed the CQ dry run.

[xlai (Olivia), 2017-03-10 17:58:57]

Description was changed from

==========
Refactor TextureHolder


BUG=
==========

to

==========
Check StaticBitmapImage has changed from Mailbox to Skia in OffscreenCanvas
commit

This is a follow-up CL of https://codereview.chromium.org/2632593003/. This will
make
"WebRtcCaptureFromElementBrowserTest.VerifyCanvasCaptureOffscreenCanvasCommitFrames"
not hit UNREACHED when it is enabled.

BUG=693229
==========

[xlai (Olivia), 2017-03-10 17:58:57]

xlai@chromium.org changed reviewers:
+ junov@chromium.org

[xlai (Olivia), 2017-03-10 17:59:16]

Description was changed from

==========
Check StaticBitmapImage has changed from Mailbox to Skia in OffscreenCanvas
commit

This is a follow-up CL of https://codereview.chromium.org/2632593003/. This will
make
"WebRtcCaptureFromElementBrowserTest.VerifyCanvasCaptureOffscreenCanvasCommitFrames"
not hit UNREACHED when it is enabled.

BUG=693229
==========

to

==========
Check StaticBitmapImage has changed from Mailbox to Skia in OffscreenCanvas
commit

This is a follow-up CL of https://codereview.chromium.org/2632593003/.
This will make
"WebRtcCaptureFromElementBrowserTest.VerifyCanvasCaptureOffscreenCanvasCommitFrames"
not hit UNREACHED when it is enabled.

BUG=693229
==========

[Justin Novosad, 2017-03-10 18:41:36]

There should be a unit test for this.

https://codereview.chromium.org/2740003004/diff/40001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.cpp
(right):

https://codereview.chromium.org/2740003004/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.cpp:414:
if (image && image->hasMailbox())
I don't think this is the right thing to do.  I think SkiaTextureHolder needs to
store the syncToken, And do a WaitSyncToken in its destructor in order to
prevent the texture from being recycled by skia while it is still used by the
compositor.

[xlai (Olivia), 2017-03-10 20:49:42]

The CQ bit was checked by xlai@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-10 20:50:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-10 20:52:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-10 20:52:57]

Dry run: Try jobs failed on following builders:
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[xlai (Olivia), 2017-03-10 21:12:51]

The CQ bit was checked by xlai@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-10 21:13:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-10 23:11:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-10 23:11:49]

Dry run: This issue passed the CQ dry run.

[xlai (Olivia), 2017-03-13 15:02:58]

On 2017/03/10 18:41:36, Justin Novosad wrote:
> There should be a unit test for this.
> 
>
https://codereview.chromium.org/2740003004/diff/40001/third_party/WebKit/Sour...
> File
>
third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.cpp
> (right):
> 
>
https://codereview.chromium.org/2740003004/diff/40001/third_party/WebKit/Sour...
>
third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.cpp:414:
> if (image && image->hasMailbox())
> I don't think this is the right thing to do.  I think SkiaTextureHolder needs
to
> store the syncToken, And do a WaitSyncToken in its destructor in order to
> prevent the texture from being recycled by skia while it is still used by the
> compositor.

This CL only changes the OffscreenCanvasFrameDispatcherImpl::ReclaimResources.
A unit test is not very suitable in such a set up as
OffscreenCanvasFrameDispatcherImpl::ReclaimResources
require a IPC back from browser. Also, existing offscreencanvas commit tests and
WebRtcCaptureFromElementBrowserTest.VerifyCanvasCaptureOffscreenCanvasCommitFrames
are able to detect
whether the code change is correct.

[Justin Novosad, 2017-03-13 15:09:49]

lgtm

[xlai (Olivia), 2017-03-13 15:14:39]

The CQ bit was checked by xlai@chromium.org

[commit-bot: I haz the power, 2017-03-13 15:15:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-13 16:57:26]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1489418079711290,
"parent_rev": "0bf96470b9eaf061401b4696979694bfc8340eae", "commit_rev":
"08583e375717564923404ed4b6fd6660ce259a97"}

[commit-bot: I haz the power, 2017-03-13 16:58:04]

Description was changed from

==========
Check StaticBitmapImage has changed from Mailbox to Skia in OffscreenCanvas
commit

This is a follow-up CL of https://codereview.chromium.org/2632593003/.
This will make
"WebRtcCaptureFromElementBrowserTest.VerifyCanvasCaptureOffscreenCanvasCommitFrames"
not hit UNREACHED when it is enabled.

BUG=693229
==========

to

==========
Check StaticBitmapImage has changed from Mailbox to Skia in OffscreenCanvas
commit

This is a follow-up CL of https://codereview.chromium.org/2632593003/.
This will make
"WebRtcCaptureFromElementBrowserTest.VerifyCanvasCaptureOffscreenCanvasCommitFrames"
not hit UNREACHED when it is enabled.

BUG=693229

Review-Url: https://codereview.chromium.org/2740003004
Cr-Commit-Position: refs/heads/master@{#456402}
Committed:
https://chromium.googlesource.com/chromium/src/+/08583e375717564923404ed4b6fd...
==========

[commit-bot: I haz the power, 2017-03-13 16:58:06]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/08583e375717564923404ed4b6fd...