Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Issue 2740003004: Check StaticBitmapImage has changed from Mailbox to Skia in OffscreenCanvas commit (Closed)

Created:
3 years, 9 months ago by xlai (Olivia)
Modified:
3 years, 9 months ago
Reviewers:
Justin Novosad
CC:
chromium-reviews, krit, drott+blinkwatch_chromium.org, blink-reviews-platform-graphics_chromium.org, dshwang, pdr+graphicswatchlist_chromium.org, jbroman, fmalita+watch_chromium.org, Rik, Stephen Chennney, blink-reviews, kinuko+watch, ajuma+watch_chromium.org, danakj+watch_chromium.org, rwlbuis, emircan
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Check StaticBitmapImage has changed from Mailbox to Skia in OffscreenCanvas commit This is a follow-up CL of https://codereview.chromium.org/2632593003/. This will make "WebRtcCaptureFromElementBrowserTest.VerifyCanvasCaptureOffscreenCanvasCommitFrames" not hit UNREACHED when it is enabled. BUG=693229 Review-Url: https://codereview.chromium.org/2740003004 Cr-Commit-Position: refs/heads/master@{#456402} Committed: https://chromium.googlesource.com/chromium/src/+/08583e375717564923404ed4b6fd6660ce259a97

Patch Set 1 #

Patch Set 2 : m #

Patch Set 3 : remove todo #

Total comments: 1

Patch Set 4 : fix #

Patch Set 5 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -8 lines) Patch
M third_party/WebKit/Source/platform/graphics/AcceleratedStaticBitmapImage.cpp View 1 2 3 4 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.cpp View 1 2 3 4 1 chunk +16 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/SkiaTextureHolder.h View 2 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 24 (18 generated)
xlai (Olivia)
3 years, 9 months ago (2017-03-10 18:00:32 UTC) #8
Justin Novosad
There should be a unit test for this. https://codereview.chromium.org/2740003004/diff/40001/third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.cpp File third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.cpp (right): https://codereview.chromium.org/2740003004/diff/40001/third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.cpp#newcode414 third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.cpp:414: if ...
3 years, 9 months ago (2017-03-10 18:41:36 UTC) #9
xlai (Olivia)
On 2017/03/10 18:41:36, Justin Novosad wrote: > There should be a unit test for this. ...
3 years, 9 months ago (2017-03-13 15:02:58 UTC) #18
Justin Novosad
lgtm
3 years, 9 months ago (2017-03-13 15:09:49 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2740003004/80001
3 years, 9 months ago (2017-03-13 15:15:09 UTC) #21
commit-bot: I haz the power
3 years, 9 months ago (2017-03-13 16:58:06 UTC) #24
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/08583e375717564923404ed4b6fd...

Powered by Google App Engine
This is Rietveld 408576698