Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(4)

Issue 2632593003: Notify listeners on OffScreenCanvas changes (Closed)

Created:
1 year, 4 months ago by emircan
Modified:
1 year, 2 months ago
CC:
chromium-reviews, krit, dshwang, drott+blinkwatch_chromium.org, ajuma+watch-canvas_chromium.org, Stephen Chennney, blink-reviews-html_chromium.org, pdr+graphicswatchlist_chromium.org, jbroman, blink-reviews-platform-graphics_chromium.org, dglazkov+blink, Rik, f(malita), blink-reviews, kinuko+watch, ajuma+watch_chromium.org, danakj+watch_chromium.org, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Notify listeners on OffScreenCanvas changes This CL adds a hook on commit() calls for OffScreenCanvas so that the changes are notified to the listeners. setPlaceholderFrame() calls are used as the hook. BUG=679610 TEST=Added layout test checking for a single frame capture and content_browsertest for a continuous capture. Also tested on html demo https://cdn.rawgit.com/uysalere/js-demos/master/offscreencanvas_user_commit.html Review-Url: https://codereview.chromium.org/2632593003 Cr-Commit-Position: refs/heads/master@{#452127} Committed: https://chromium.googlesource.com/chromium/src/+/8db1658c62cfe49d1be14bc0186d4c20152cfd84

Patch Set 1 : #

Total comments: 2

Patch Set 2 : Remove generate_tests use. #

Patch Set 3 : Remove transferFromImageBitmap(). #

Patch Set 4 : Rebase #

Patch Set 5 : #

Patch Set 6 : #

Messages

Total messages: 90 (66 generated)
emircan
PTAL. Note that currently testOffScreenCanvasTransferBitmaps() tests fail. I don't see why they would. Let me ...
1 year, 4 months ago (2017-01-19 01:31:00 UTC) #10
Justin Novosad
https://codereview.chromium.org/2632593003/diff/60001/third_party/WebKit/LayoutTests/fast/mediacapturefromelement/CanvasCaptureMediaStream-offscreencanvas.html File third_party/WebKit/LayoutTests/fast/mediacapturefromelement/CanvasCaptureMediaStream-offscreencanvas.html (right): https://codereview.chromium.org/2632593003/diff/60001/third_party/WebKit/LayoutTests/fast/mediacapturefromelement/CanvasCaptureMediaStream-offscreencanvas.html#newcode40 third_party/WebKit/LayoutTests/fast/mediacapturefromelement/CanvasCaptureMediaStream-offscreencanvas.html:40: generate_tests(testOffScreenCanvasCommits, [ The testharness documentation says you can't use ...
1 year, 4 months ago (2017-01-19 19:06:31 UTC) #13
emircan
https://codereview.chromium.org/2632593003/diff/60001/third_party/WebKit/LayoutTests/fast/mediacapturefromelement/CanvasCaptureMediaStream-offscreencanvas.html File third_party/WebKit/LayoutTests/fast/mediacapturefromelement/CanvasCaptureMediaStream-offscreencanvas.html (right): https://codereview.chromium.org/2632593003/diff/60001/third_party/WebKit/LayoutTests/fast/mediacapturefromelement/CanvasCaptureMediaStream-offscreencanvas.html#newcode40 third_party/WebKit/LayoutTests/fast/mediacapturefromelement/CanvasCaptureMediaStream-offscreencanvas.html:40: generate_tests(testOffScreenCanvasCommits, [ On 2017/01/19 19:06:31, Justin Novosad wrote: > ...
1 year, 4 months ago (2017-01-19 20:50:52 UTC) #16
Justin Novosad
On 2017/01/19 20:50:52, emircan wrote: > https://codereview.chromium.org/2632593003/diff/60001/third_party/WebKit/LayoutTests/fast/mediacapturefromelement/CanvasCaptureMediaStream-offscreencanvas.html > File > third_party/WebKit/LayoutTests/fast/mediacapturefromelement/CanvasCaptureMediaStream-offscreencanvas.html > (right): > > ...
1 year, 4 months ago (2017-01-19 21:01:29 UTC) #17
emircan
On 2017/01/19 21:01:29, Justin Novosad wrote: > > Right. I have a WIP CL that ...
1 year, 4 months ago (2017-01-19 23:06:52 UTC) #22
emircan
I addressed transferFromImageBitmap() issues in this CL: https://codereview.chromium.org/2683343002/ Here I am going to only address ...
1 year, 3 months ago (2017-02-10 23:38:23 UTC) #37
emircan
junov@, I rebased and added the corresponding content_browsertests here as well. Now, this code is ...
1 year, 3 months ago (2017-02-15 22:49:35 UTC) #55
Justin Novosad
Olivia, please a look at this.
1 year, 3 months ago (2017-02-16 15:03:02 UTC) #57
xlai (Olivia)
On 2017/02/16 15:03:02, Justin Novosad wrote: > Olivia, please a look at this. My guess ...
1 year, 3 months ago (2017-02-16 17:18:11 UTC) #58
emircan
On 2017/02/16 17:18:11, xlai (Olivia) wrote: > On 2017/02/16 15:03:02, Justin Novosad wrote: > > ...
1 year, 3 months ago (2017-02-16 19:22:36 UTC) #61
xlai (Olivia)
On 2017/02/16 19:22:36, emircan wrote: > On 2017/02/16 17:18:11, xlai (Olivia) wrote: > > On ...
1 year, 3 months ago (2017-02-16 19:51:11 UTC) #62
emircan
On 2017/02/16 19:51:11, xlai (Olivia) wrote: > Hmmm, you're still overwriting MailboxTextureHolder to > SkiaTextureHolder. ...
1 year, 3 months ago (2017-02-16 22:22:15 UTC) #66
xlai (Olivia)
lgtm
1 year, 3 months ago (2017-02-16 22:25:06 UTC) #68
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2632593003/320001
1 year, 3 months ago (2017-02-17 01:42:35 UTC) #72
xlai (Olivia)
On 2017/02/17 01:42:35, commit-bot: I haz the power wrote: > CQ is trying da patch. ...
1 year, 3 months ago (2017-02-17 02:10:00 UTC) #73
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
1 year, 3 months ago (2017-02-17 03:44:56 UTC) #75
emircan
On 2017/02/17 02:10:00, xlai (Olivia) wrote: > On 2017/02/17 01:42:35, commit-bot: I haz the power ...
1 year, 3 months ago (2017-02-17 18:47:03 UTC) #76
Justin Novosad
lgtm
1 year, 3 months ago (2017-02-21 18:27:55 UTC) #77
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2632593003/320001
1 year, 3 months ago (2017-02-21 18:55:50 UTC) #79
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_chromeos_rel_ng on ...
1 year, 3 months ago (2017-02-21 20:58:16 UTC) #81
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2632593003/320001
1 year, 3 months ago (2017-02-21 21:14:11 UTC) #83
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
1 year, 2 months ago (2017-02-22 01:38:05 UTC) #85
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2632593003/320001
1 year, 2 months ago (2017-02-22 17:38:05 UTC) #87
commit-bot: I haz the power
1 year, 2 months ago (2017-02-22 18:10:27 UTC) #90
Message was sent while issue was closed.
Committed patchset #6 (id:320001) as
https://chromium.googlesource.com/chromium/src/+/8db1658c62cfe49d1be14bc0186d...

Powered by Google App Engine
This is Rietveld 408576698