Issue 27400003: Get rid of custom code for Window.location attribute setter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 27400003: Get rid of custom code for Window.location attribute setter (Closed)

Created:
7 years, 2 months ago by Inactive

Modified:
7 years, 2 months ago

Reviewers:
haraken, abarth-chromium

CC:
blink-reviews, Nils Barth (inactive), kojih, jsbell+bindings_chromium.org, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, Nate Chapin, Inactive

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Get rid of custom code for Window.location attribute setter Get rid of custom code for Window.location attribute setter by leveraging the generator support for [PutForwards=x] IDL extended attribute. BUG=307045 R=haraken Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=159737

Patch Set 1 #

Patch Set 2 : Keep attribute Replaceable #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -14 lines)			Patch
M	Source/bindings/scripts/code_generator_v8.pm	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/bindings/v8/custom/V8WindowCustom.cpp	View		2 chunks	+0 lines, -11 lines	0 comments	Download
M	Source/core/frame/Window.idl	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Inactive

Here is the diff on V8DOMWindow.cpp: http://pastebin.com/mYRhEaAw

7 years, 2 months ago (2013-10-15 21:24:52 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/27400003/3001

7 years, 2 months ago (2013-10-15 22:28:50 UTC) #3

Message was sent while issue was closed.

Change committed as 159737

Expand Messages | Collapse Messages