Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Unified Diff: Source/bindings/scripts/code_generator_v8.pm

Issue 27400003: Get rid of custom code for Window.location attribute setter (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Keep attribute Replaceable Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/bindings/v8/custom/V8WindowCustom.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/scripts/code_generator_v8.pm
diff --git a/Source/bindings/scripts/code_generator_v8.pm b/Source/bindings/scripts/code_generator_v8.pm
index 886ed7d7003417adba21f53f45d0ac51515a35f9..e20239165ab6874bdd50d9908c2f3950a3244ecf 100644
--- a/Source/bindings/scripts/code_generator_v8.pm
+++ b/Source/bindings/scripts/code_generator_v8.pm
@@ -3110,7 +3110,7 @@ sub GenerateAttributeConfigurationParameters
$getterForMainWorld = "${getter}ForMainWorld";
$setterForMainWorld = "${setter}ForMainWorld";
- if (!HasCustomSetter($attribute) && $attrExt->{"Replaceable"}) {
+ if (!HasCustomSetter($attribute) && !$attrExt->{"PutForwards"} && $attrExt->{"Replaceable"}) {
$setter = "${implClassName}V8Internal::${implClassName}ReplaceableAttributeSetterCallback";
$setterForMainWorld = "0";
}
@@ -4088,7 +4088,7 @@ END
GenerateNormalAttributeGetter($attribute, $interface, "ForMainWorld");
GenerateNormalAttributeGetterCallback($attribute, $interface, "ForMainWorld");
}
- if (!HasCustomSetter($attribute) && $attrExt->{"Replaceable"}) {
+ if (!HasCustomSetter($attribute) && !$attrExt->{"PutForwards"} && $attrExt->{"Replaceable"}) {
$hasReplaceable = 1;
} elsif (!IsReadonly($attribute)) {
GenerateNormalAttributeSetter($attribute, $interface, "");
« no previous file with comments | « no previous file | Source/bindings/v8/custom/V8WindowCustom.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698