Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Side by Side Diff: Source/bindings/scripts/code_generator_v8.pm

Issue 27400003: Get rid of custom code for Window.location attribute setter (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Keep attribute Replaceable Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | Source/bindings/v8/custom/V8WindowCustom.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (C) 2005, 2006 Nikolas Zimmermann <zimmermann@kde.org> 1 # Copyright (C) 2005, 2006 Nikolas Zimmermann <zimmermann@kde.org>
2 # Copyright (C) 2006 Anders Carlsson <andersca@mac.com> 2 # Copyright (C) 2006 Anders Carlsson <andersca@mac.com>
3 # Copyright (C) 2006 Samuel Weinig <sam.weinig@gmail.com> 3 # Copyright (C) 2006 Samuel Weinig <sam.weinig@gmail.com>
4 # Copyright (C) 2006 Alexey Proskuryakov <ap@webkit.org> 4 # Copyright (C) 2006 Alexey Proskuryakov <ap@webkit.org>
5 # Copyright (C) 2006 Apple Computer, Inc. 5 # Copyright (C) 2006 Apple Computer, Inc.
6 # Copyright (C) 2007, 2008, 2009, 2012 Google Inc. 6 # Copyright (C) 2007, 2008, 2009, 2012 Google Inc.
7 # Copyright (C) 2009 Cameron McCormack <cam@mcc.id.au> 7 # Copyright (C) 2009 Cameron McCormack <cam@mcc.id.au>
8 # Copyright (C) Research In Motion Limited 2010. All rights reserved. 8 # Copyright (C) Research In Motion Limited 2010. All rights reserved.
9 # Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies) 9 # Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies)
10 # Copyright (C) 2012 Ericsson AB. All rights reserved. 10 # Copyright (C) 2012 Ericsson AB. All rights reserved.
(...skipping 3092 matching lines...) Expand 10 before | Expand all | Expand 10 after
3103 $setter = "${implClassName}V8Internal::${implClassName}ReplaceableAttrib uteSetterCallback"; 3103 $setter = "${implClassName}V8Internal::${implClassName}ReplaceableAttrib uteSetterCallback";
3104 $getterForMainWorld = "0"; 3104 $getterForMainWorld = "0";
3105 $setterForMainWorld = "0"; 3105 $setterForMainWorld = "0";
3106 } else { 3106 } else {
3107 # Default Getter and Setter 3107 # Default Getter and Setter
3108 $getter = "${implClassName}V8Internal::${attrName}AttributeGetterCallbac k"; 3108 $getter = "${implClassName}V8Internal::${attrName}AttributeGetterCallbac k";
3109 $setter = "${implClassName}V8Internal::${attrName}AttributeSetterCallbac k"; 3109 $setter = "${implClassName}V8Internal::${attrName}AttributeSetterCallbac k";
3110 $getterForMainWorld = "${getter}ForMainWorld"; 3110 $getterForMainWorld = "${getter}ForMainWorld";
3111 $setterForMainWorld = "${setter}ForMainWorld"; 3111 $setterForMainWorld = "${setter}ForMainWorld";
3112 3112
3113 if (!HasCustomSetter($attribute) && $attrExt->{"Replaceable"}) { 3113 if (!HasCustomSetter($attribute) && !$attrExt->{"PutForwards"} && $attrE xt->{"Replaceable"}) {
3114 $setter = "${implClassName}V8Internal::${implClassName}ReplaceableAt tributeSetterCallback"; 3114 $setter = "${implClassName}V8Internal::${implClassName}ReplaceableAt tributeSetterCallback";
3115 $setterForMainWorld = "0"; 3115 $setterForMainWorld = "0";
3116 } 3116 }
3117 } 3117 }
3118 3118
3119 # Read only attributes 3119 # Read only attributes
3120 if (IsReadonly($attribute)) { 3120 if (IsReadonly($attribute)) {
3121 $setter = "0"; 3121 $setter = "0";
3122 $setterForMainWorld = "0"; 3122 $setterForMainWorld = "0";
3123 } 3123 }
(...skipping 957 matching lines...) Expand 10 before | Expand all | Expand 10 after
4081 if ($attrType eq "SerializedScriptValue") { 4081 if ($attrType eq "SerializedScriptValue") {
4082 AddToImplIncludes("bindings/v8/SerializedScriptValue.h"); 4082 AddToImplIncludes("bindings/v8/SerializedScriptValue.h");
4083 } 4083 }
4084 4084
4085 GenerateNormalAttributeGetter($attribute, $interface, ""); 4085 GenerateNormalAttributeGetter($attribute, $interface, "");
4086 GenerateNormalAttributeGetterCallback($attribute, $interface, ""); 4086 GenerateNormalAttributeGetterCallback($attribute, $interface, "");
4087 if ($attrExt->{"PerWorldBindings"}) { 4087 if ($attrExt->{"PerWorldBindings"}) {
4088 GenerateNormalAttributeGetter($attribute, $interface, "ForMainWorld" ); 4088 GenerateNormalAttributeGetter($attribute, $interface, "ForMainWorld" );
4089 GenerateNormalAttributeGetterCallback($attribute, $interface, "ForMa inWorld"); 4089 GenerateNormalAttributeGetterCallback($attribute, $interface, "ForMa inWorld");
4090 } 4090 }
4091 if (!HasCustomSetter($attribute) && $attrExt->{"Replaceable"}) { 4091 if (!HasCustomSetter($attribute) && !$attrExt->{"PutForwards"} && $attrE xt->{"Replaceable"}) {
4092 $hasReplaceable = 1; 4092 $hasReplaceable = 1;
4093 } elsif (!IsReadonly($attribute)) { 4093 } elsif (!IsReadonly($attribute)) {
4094 GenerateNormalAttributeSetter($attribute, $interface, ""); 4094 GenerateNormalAttributeSetter($attribute, $interface, "");
4095 GenerateNormalAttributeSetterCallback($attribute, $interface, ""); 4095 GenerateNormalAttributeSetterCallback($attribute, $interface, "");
4096 if ($attrExt->{"PerWorldBindings"}) { 4096 if ($attrExt->{"PerWorldBindings"}) {
4097 GenerateNormalAttributeSetter($attribute, $interface, "ForMainWorl d"); 4097 GenerateNormalAttributeSetter($attribute, $interface, "ForMainWorl d");
4098 GenerateNormalAttributeSetterCallback($attribute, $interface, "For MainWorld"); 4098 GenerateNormalAttributeSetterCallback($attribute, $interface, "For MainWorld");
4099 } 4099 }
4100 } 4100 }
4101 } 4101 }
(...skipping 2117 matching lines...) Expand 10 before | Expand all | Expand 10 after
6219 my $interface = shift; 6219 my $interface = shift;
6220 6220
6221 return 1 if $interface->extendedAttributes->{"CustomToV8"}; 6221 return 1 if $interface->extendedAttributes->{"CustomToV8"};
6222 return 1 if $interface->extendedAttributes->{"SpecialWrapFor"}; 6222 return 1 if $interface->extendedAttributes->{"SpecialWrapFor"};
6223 return 1 if InheritsInterface($interface, "Document"); 6223 return 1 if InheritsInterface($interface, "Document");
6224 6224
6225 return 0; 6225 return 0;
6226 } 6226 }
6227 6227
6228 1; 6228 1;
OLDNEW
« no previous file with comments | « no previous file | Source/bindings/v8/custom/V8WindowCustom.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698