Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Unified Diff: ios/chrome/browser/ui/content_suggestions/content_suggestions_data_sink.h

Issue 2739873003: Remove suggestions notified as invalid (Closed)
Patch Set: Fix the logic Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/ui/content_suggestions/content_suggestions_data_sink.h
diff --git a/ios/chrome/browser/ui/content_suggestions/content_suggestions_data_sink.h b/ios/chrome/browser/ui/content_suggestions/content_suggestions_data_sink.h
index ebf8bfa5e457993cbf802a4c54922545fe8bb405..ab9191f5c4da8e7df10078a8291adb99c684b34b 100644
--- a/ios/chrome/browser/ui/content_suggestions/content_suggestions_data_sink.h
+++ b/ios/chrome/browser/ui/content_suggestions/content_suggestions_data_sink.h
@@ -5,6 +5,8 @@
#ifndef IOS_CHROME_BROWSER_UI_CONTENT_SUGGESTIONS_CONTENT_SUGGESTIONS_DATA_SINK_H_
#define IOS_CHROME_BROWSER_UI_CONTENT_SUGGESTIONS_CONTENT_SUGGESTIONS_DATA_SINK_H_
+@class ContentSuggestionIdentifier;
+
// Data sink for the ContentSuggestions. It will be notified when new data needs
// to be pulled.
@protocol ContentSuggestionsDataSink
@@ -12,6 +14,11 @@
// Notifies the Data Sink that new data is available.
- (void)dataAvailable;
+// The suggestion associated with |suggestionIdentifier| has been invalidated
+// and should be cleared now. This is why this method is about the data source
+// pushing information to the data sink.
+- (void)clearSuggestion:(ContentSuggestionIdentifier*)suggestionIdentifier;
lpromero 2017/03/09 10:00:44 Maybe: has been invalidated "in the backend"? Or e
gambard 2017/03/09 12:21:23 Well, "by the data source" maybe. I am not sure th
lpromero 2017/03/09 12:59:23 Well, there are and there will be more and more cl
gambard 2017/03/09 13:32:49 Done.
+
@end
#endif // IOS_CHROME_BROWSER_UI_CONTENT_SUGGESTIONS_CONTENT_SUGGESTIONS_DATA_SINK_H_

Powered by Google App Engine
This is Rietveld 408576698