Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Side by Side Diff: ios/chrome/browser/ui/content_suggestions/content_suggestions_data_sink.h

Issue 2739873003: Remove suggestions notified as invalid (Closed)
Patch Set: Fix the logic Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2017 The Chromium Authors. All rights reserved. 1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef IOS_CHROME_BROWSER_UI_CONTENT_SUGGESTIONS_CONTENT_SUGGESTIONS_DATA_SINK_ H_ 5 #ifndef IOS_CHROME_BROWSER_UI_CONTENT_SUGGESTIONS_CONTENT_SUGGESTIONS_DATA_SINK_ H_
6 #define IOS_CHROME_BROWSER_UI_CONTENT_SUGGESTIONS_CONTENT_SUGGESTIONS_DATA_SINK_ H_ 6 #define IOS_CHROME_BROWSER_UI_CONTENT_SUGGESTIONS_CONTENT_SUGGESTIONS_DATA_SINK_ H_
7 7
8 @class ContentSuggestionIdentifier;
9
8 // Data sink for the ContentSuggestions. It will be notified when new data needs 10 // Data sink for the ContentSuggestions. It will be notified when new data needs
9 // to be pulled. 11 // to be pulled.
10 @protocol ContentSuggestionsDataSink 12 @protocol ContentSuggestionsDataSink
11 13
12 // Notifies the Data Sink that new data is available. 14 // Notifies the Data Sink that new data is available.
13 - (void)dataAvailable; 15 - (void)dataAvailable;
14 16
17 // The suggestion associated with |suggestionIdentifier| has been invalidated
18 // and should be cleared now. This is why this method is about the data source
19 // pushing information to the data sink.
20 - (void)clearSuggestion:(ContentSuggestionIdentifier*)suggestionIdentifier;
lpromero 2017/03/09 10:00:44 Maybe: has been invalidated "in the backend"? Or e
gambard 2017/03/09 12:21:23 Well, "by the data source" maybe. I am not sure th
lpromero 2017/03/09 12:59:23 Well, there are and there will be more and more cl
gambard 2017/03/09 13:32:49 Done.
21
15 @end 22 @end
16 23
17 #endif // IOS_CHROME_BROWSER_UI_CONTENT_SUGGESTIONS_CONTENT_SUGGESTIONS_DATA_SI NK_H_ 24 #endif // IOS_CHROME_BROWSER_UI_CONTENT_SUGGESTIONS_CONTENT_SUGGESTIONS_DATA_SI NK_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698