ios/chrome/browser/content_suggestions/content_suggestions_mediator.mm - Issue 2739873003: Remove suggestions notified as invalid

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/content_suggestions/content_suggestions_mediator.mm

Issue 2739873003: Remove suggestions notified as invalid (Closed)

Patch Set: Fix the logic Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ios/chrome/browser/content_suggestions/content_suggestions_coordinator.mm ('k') | ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.mm » ('j') | ios/chrome/browser/ui/content_suggestions/content_suggestions_data_sink.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ios/chrome/browser/content_suggestions/content_suggestions_mediator.mm

diff --git a/ios/chrome/browser/content_suggestions/content_suggestions_mediator.mm b/ios/chrome/browser/content_suggestions/content_suggestions_mediator.mm

index 52b7c7caca1b39dc294f10938fbf5f2cdd9aeb37..a881c70968f0daf545027dd118883f2dbefa9b27 100644

--- a/ios/chrome/browser/content_suggestions/content_suggestions_mediator.mm

+++ b/ios/chrome/browser/content_suggestions/content_suggestions_mediator.mm

@@ -200,7 +200,15 @@ ntp_snippets::ContentSuggestion::ID SuggestionIDForSectionID(

(ntp_snippets::ContentSuggestionsService*)suggestionsService

SuggestionInvalidated:

lpromero 2017/03/09 10:00:44 Missed it before: lowercase S.

gambard 2017/03/09 12:21:23 Done.

(const ntp_snippets::ContentSuggestion::ID&)suggestion_id {

- // Update dataSink.

+ ContentSuggestionsCategoryWrapper* wrapper =

+ [[ContentSuggestionsCategoryWrapper alloc]

+ initWithCategory:suggestion_id.category()];

+ ContentSuggestionIdentifier* suggestionIdentifier =

+ [[ContentSuggestionIdentifier alloc] init];

+ suggestionIdentifier.IDInSection = suggestion_id.id_within_category();

+ suggestionIdentifier.sectionInfo = self.sectionInformationByCategory[wrapper];

+ [self.dataSink clearSuggestion:suggestionIdentifier];

}

- (void)contentSuggestionsServiceFullRefreshRequired: