Remove suggestions notified as invalid

Remove suggestions notified as invalid

Remove from the UI the suggestions marked as invalid by the backend content
suggestion service.

BUG=699124
Review-Url: https://codereview.chromium.org/2739873003
Cr-Commit-Position: refs/heads/master@{#455733}
Committed: https://chromium.googlesource.com/chromium/src/+/31069226a11b4a51b02b794fe6ca04342703a069

[gambard, 2017-03-09 08:53:09]

Description was changed from

==========
Remove suggestion notified as invalid

Remove from the UI the suggestions marked as invalid by the content suggestion
service.

BUG=699124
==========

to

==========
Remove suggestions notified as invalid

Remove from the UI the suggestions marked as invalid by the content suggestion
service.

BUG=699124
==========

[gambard, 2017-03-09 08:55:23]

gambard@chromium.org changed reviewers:
+ lpromero@chromium.org

[gambard, 2017-03-09 08:55:24]

PTAL

[lpromero, 2017-03-09 10:00:45]

Maybe add also to the description: "notified as invalid by the backend" or
equivalent.

https://codereview.chromium.org/2739873003/diff/20001/ios/chrome/browser/cont...
File ios/chrome/browser/content_suggestions/content_suggestions_mediator.mm
(right):

https://codereview.chromium.org/2739873003/diff/20001/ios/chrome/browser/cont...
ios/chrome/browser/content_suggestions/content_suggestions_mediator.mm:201:
SuggestionInvalidated:
Missed it before: lowercase S.

https://codereview.chromium.org/2739873003/diff/20001/ios/chrome/browser/ui/c...
File ios/chrome/browser/ui/content_suggestions/content_suggestions_data_sink.h
(right):

https://codereview.chromium.org/2739873003/diff/20001/ios/chrome/browser/ui/c...
ios/chrome/browser/ui/content_suggestions/content_suggestions_data_sink.h:20: -
(void)clearSuggestion:(ContentSuggestionIdentifier*)suggestionIdentifier;
Maybe: has been invalidated "in the backend"? Or equivalent.

https://codereview.chromium.org/2739873003/diff/20001/ios/chrome/browser/ui/c...
File
ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.h
(right):

https://codereview.chromium.org/2739873003/diff/20001/ios/chrome/browser/ui/c...
ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.h:33:
// Override from superclass.
Add that it's to have a more specific type.

[lpromero, 2017-03-09 10:00:51]

lgtm

[gambard, 2017-03-09 12:16:54]

Description was changed from

==========
Remove suggestions notified as invalid

Remove from the UI the suggestions marked as invalid by the content suggestion
service.

BUG=699124
==========

to

==========
Remove suggestions notified as invalid

Remove from the UI the suggestions marked as invalid by the backend content
suggestion service.

BUG=699124
==========

[gambard, 2017-03-09 12:21:23]

Thanks!

https://codereview.chromium.org/2739873003/diff/20001/ios/chrome/browser/cont...
File ios/chrome/browser/content_suggestions/content_suggestions_mediator.mm
(right):

https://codereview.chromium.org/2739873003/diff/20001/ios/chrome/browser/cont...
ios/chrome/browser/content_suggestions/content_suggestions_mediator.mm:201:
SuggestionInvalidated:
On 2017/03/09 10:00:44, lpromero wrote:
> Missed it before: lowercase S.

Done.

https://codereview.chromium.org/2739873003/diff/20001/ios/chrome/browser/ui/c...
File ios/chrome/browser/ui/content_suggestions/content_suggestions_data_sink.h
(right):

https://codereview.chromium.org/2739873003/diff/20001/ios/chrome/browser/ui/c...
ios/chrome/browser/ui/content_suggestions/content_suggestions_data_sink.h:20: -
(void)clearSuggestion:(ContentSuggestionIdentifier*)suggestionIdentifier;
On 2017/03/09 10:00:44, lpromero wrote:
> Maybe: has been invalidated "in the backend"? Or equivalent.

Well, "by the data source" maybe. I am not sure this is relevant: is it
important to know who invalidated it?

https://codereview.chromium.org/2739873003/diff/20001/ios/chrome/browser/ui/c...
File
ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.h
(right):

https://codereview.chromium.org/2739873003/diff/20001/ios/chrome/browser/ui/c...
ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.h:33:
// Override from superclass.
On 2017/03/09 10:00:44, lpromero wrote:
> Add that it's to have a more specific type.

Done.

[lpromero, 2017-03-09 12:59:23]

https://codereview.chromium.org/2739873003/diff/20001/ios/chrome/browser/ui/c...
File ios/chrome/browser/ui/content_suggestions/content_suggestions_data_sink.h
(right):

https://codereview.chromium.org/2739873003/diff/20001/ios/chrome/browser/ui/c...
ios/chrome/browser/ui/content_suggestions/content_suggestions_data_sink.h:20: -
(void)clearSuggestion:(ContentSuggestionIdentifier*)suggestionIdentifier;
On 2017/03/09 12:21:23, gambard wrote:
> On 2017/03/09 10:00:44, lpromero wrote:
> > Maybe: has been invalidated "in the backend"? Or equivalent.
> 
> Well, "by the data source" maybe. I am not sure this is relevant: is it
> important to know who invalidated it?

Well, there are and there will be more and more classes. I think it helps
understand when we mention the context too.

[gambard, 2017-03-09 13:32:36]

The CQ bit was checked by gambard@chromium.org

[gambard, 2017-03-09 13:32:38]

The patchset sent to the CQ was uploaded after l-g-t-m from
lpromero@chromium.org
Link to the patchset: https://codereview.chromium.org/2739873003/#ps60001
(title: "Update comment")

[gambard, 2017-03-09 13:32:49]

Thanks!

https://codereview.chromium.org/2739873003/diff/20001/ios/chrome/browser/ui/c...
File ios/chrome/browser/ui/content_suggestions/content_suggestions_data_sink.h
(right):

https://codereview.chromium.org/2739873003/diff/20001/ios/chrome/browser/ui/c...
ios/chrome/browser/ui/content_suggestions/content_suggestions_data_sink.h:20: -
(void)clearSuggestion:(ContentSuggestionIdentifier*)suggestionIdentifier;
On 2017/03/09 12:59:23, lpromero wrote:
> On 2017/03/09 12:21:23, gambard wrote:
> > On 2017/03/09 10:00:44, lpromero wrote:
> > > Maybe: has been invalidated "in the backend"? Or equivalent.
> > 
> > Well, "by the data source" maybe. I am not sure this is relevant: is it
> > important to know who invalidated it?
> 
> Well, there are and there will be more and more classes. I think it helps
> understand when we mention the context too.

Done.

[commit-bot: I haz the power, 2017-03-09 13:33:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-09 13:58:55]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1489066356195700,
"parent_rev": "75a414cfbc5ef07035f7e5ce184059a1061fa044", "commit_rev":
"31069226a11b4a51b02b794fe6ca04342703a069"}

[commit-bot: I haz the power, 2017-03-09 13:59:39]

Description was changed from

==========
Remove suggestions notified as invalid

Remove from the UI the suggestions marked as invalid by the backend content
suggestion service.

BUG=699124
==========

to

==========
Remove suggestions notified as invalid

Remove from the UI the suggestions marked as invalid by the backend content
suggestion service.

BUG=699124

Review-Url: https://codereview.chromium.org/2739873003
Cr-Commit-Position: refs/heads/master@{#455733}
Committed:
https://chromium.googlesource.com/chromium/src/+/31069226a11b4a51b02b794fe6ca...
==========

[commit-bot: I haz the power, 2017-03-09 13:59:40]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/31069226a11b4a51b02b794fe6ca...