Rename matcher OpenLinkInNewTabMenuItem as OpenLinkInNewTabButton.

Rename matcher OpenLinkInNewTabMenuItem as OpenLinkInNewTabButton.

All of our other matchers like this end in "Button", so this makes
it consistent. If we want to distinguish menu items, it should be
done everywhere.

BUG=698774
Review-Url: https://codereview.chromium.org/2739833003
Cr-Commit-Position: refs/heads/master@{#455520}
Committed: https://chromium.googlesource.com/chromium/src/+/cc17746adff54984afff480136733114c6b3704b

[baxley, 2017-03-08 16:51:52]

baxley@chromium.org changed reviewers:
+ eugenebut@chromium.org

[baxley, 2017-03-08 16:51:53]

Sorry for the churn, but I want to make this consistent, and if I don't do it
now, It'll likely never be done...

[Eugene But (OOO till 7-30), 2017-03-08 19:21:40]

lgtm

[baxley, 2017-03-08 19:24:54]

The CQ bit was checked by baxley@chromium.org

[commit-bot: I haz the power, 2017-03-08 19:25:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-08 19:52:57]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1489001094655960, "parent_rev":
"54069df248fa82893cda255d91c1704e01ea00a6", "commit_rev":
"cc17746adff54984afff480136733114c6b3704b"}

[commit-bot: I haz the power, 2017-03-08 19:53:43]

Description was changed from

==========
Rename matcher OpenLinkInNewTabMenuItem as OpenLinkInNewTabButton.

All of our other matchers like this end in "Button", so this makes
it consistent. If we want to distinguish menu items, it should be
done everywhere.

BUG=698774
==========

to

==========
Rename matcher OpenLinkInNewTabMenuItem as OpenLinkInNewTabButton.

All of our other matchers like this end in "Button", so this makes
it consistent. If we want to distinguish menu items, it should be
done everywhere.

BUG=698774

Review-Url: https://codereview.chromium.org/2739833003
Cr-Commit-Position: refs/heads/master@{#455520}
Committed:
https://chromium.googlesource.com/chromium/src/+/cc17746adff54984afff48013673...
==========

[commit-bot: I haz the power, 2017-03-08 19:53:45]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/cc17746adff54984afff48013673...