Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Issue 2739833003: Rename matcher OpenLinkInNewTabMenuItem as OpenLinkInNewTabButton. (Closed)

Created:
3 years, 9 months ago by baxley
Modified:
3 years, 9 months ago
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, asvitkine+watch_chromium.org, marq+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename matcher OpenLinkInNewTabMenuItem as OpenLinkInNewTabButton. All of our other matchers like this end in "Button", so this makes it consistent. If we want to distinguish menu items, it should be done everywhere. BUG=698774 Review-Url: https://codereview.chromium.org/2739833003 Cr-Commit-Position: refs/heads/master@{#455520} Committed: https://chromium.googlesource.com/chromium/src/+/cc17746adff54984afff480136733114c6b3704b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
M ios/chrome/browser/context_menu/context_menu_egtest.mm View 3 chunks +3 lines, -4 lines 0 comments Download
M ios/chrome/browser/metrics/tab_usage_recorder_egtest.mm View 2 chunks +3 lines, -2 lines 0 comments Download
M ios/chrome/browser/ui/history/history_ui_egtest.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M ios/chrome/test/earl_grey/chrome_matchers.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/test/earl_grey/chrome_matchers.mm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
baxley
Sorry for the churn, but I want to make this consistent, and if I don't ...
3 years, 9 months ago (2017-03-08 16:51:53 UTC) #2
Eugene But (OOO till 7-30)
lgtm
3 years, 9 months ago (2017-03-08 19:21:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2739833003/1
3 years, 9 months ago (2017-03-08 19:25:42 UTC) #5
commit-bot: I haz the power
3 years, 9 months ago (2017-03-08 19:53:45 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/cc17746adff54984afff48013673...

Powered by Google App Engine
This is Rietveld 408576698