Rename matcher OpenLinkInNewTabMenuItem as OpenLinkInNewTabButton.

ios/chrome/browser/context_menu/context_menu_egtest.mm

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import <EarlGrey/EarlGrey.h>
 #import <UIKit/UIKit.h>
 #import <XCTest/XCTest.h>
 
 #include "base/strings/sys_string_conversions.h"
 #include "ios/chrome/browser/ui/ui_util.h"
@@ skipping 12 matching lines @@
 #import "ios/web/public/test/earl_grey/web_view_matchers.h"
 #import "ios/web/public/test/http_server.h"
 #import "ios/web/public/test/http_server_util.h"
 #include "url/gurl.h"
 
 #if !defined(__has_feature) || !__has_feature(objc_arc)
 #error "This file requires ARC support."
 #endif
 
 using chrome_test_util::ButtonWithAccessibilityLabelId;
+using chrome_test_util::OpenLinkInNewTabButton;
 
 namespace {
 const char kUrlChromiumLogoPage[] =
     "http://ios/testing/data/http_server_files/chromium_logo_page.html";
 const char kUrlChromiumLogoImg[] =
     "http://ios/testing/data/http_server_files/chromium_logo.png";
 const char kUrlInitialPage[] = "http://scenarioContextMenuOpenInNewTab";
 const char kUrlDestinationPage[] = "http://destination";
 const char kChromiumImageID[] = "chromium_image";
 const char kDestinationLinkID[] = "link";
@@ skipping 124 matching lines @@
 
   // The initial page contains a link to the destination page.
   responses[initialURL] = "<a style='margin-left:50px' href='" +
                           destinationURL.spec() + "' id='link'>link</a>";
   responses[destinationURL] = kDestinationHtml;
 
   web::test::SetUpSimpleHttpServer(responses);
   [ChromeEarlGrey loadURL:initialURL];
   chrome_test_util::AssertMainTabCount(1U);
 
-  LongPressElementAndTapOnButton(kDestinationLinkID,
-                                 chrome_test_util::OpenLinkInNewTabMenuItem());
+  LongPressElementAndTapOnButton(kDestinationLinkID, OpenLinkInNewTabButton());
 
   SelectTabAtIndexInCurrentMode(1U);
 
   // Verify url and tab count.
   [[EarlGrey selectElementWithMatcher:chrome_test_util::OmniboxText(
                                           destinationURL.GetContent())]
       assertWithMatcher:grey_notNil()];
   chrome_test_util::AssertMainTabCount(2U);
 }
 
@@ skipping 21 matching lines @@
 
   // Scroll down on the web view to make the link visible.
   [[EarlGrey
       selectElementWithMatcher:WebViewScrollView(
                                    chrome_test_util::GetCurrentWebState())]
       performAction:grey_swipeFastInDirection(kGREYDirectionUp)];
   [[EarlGrey selectElementWithMatcher:chrome_test_util::WebViewContainingText(
                                           kDestinationLinkID)]
       assertWithMatcher:grey_notNil()];
 
-  LongPressElementAndTapOnButton(kDestinationLinkID,
-                                 chrome_test_util::OpenLinkInNewTabMenuItem());
+  LongPressElementAndTapOnButton(kDestinationLinkID, OpenLinkInNewTabButton());
 
   // Earl Grey cannot preperly synchronize some animations, so adding a
   // WaitUntilCondition to wait for the new tab opening animation to finish
   // and the scroll view to become interactable.
   ConditionBlock condition = ^{
     NSError* error = nil;
     [[EarlGrey
         selectElementWithMatcher:WebViewScrollView(
                                      chrome_test_util::GetCurrentWebState())]
         assertWithMatcher:grey_interactable()
@@ skipping 15 matching lines @@
   SelectTabAtIndexInCurrentMode(1U);
 
   // Verify url and tab count.
   [[EarlGrey selectElementWithMatcher:chrome_test_util::OmniboxText(
                                           destinationURL.GetContent())]
       assertWithMatcher:grey_notNil()];
   chrome_test_util::AssertMainTabCount(2U);
 }
 
 @end