Issue 2739743003: [Merge M58] Adopt UI review feedback

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2739743003: [Merge M58] Adopt UI review feedback (Closed)

Created:
3 years, 9 months ago by Mathieu

Modified:
3 years, 9 months ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/pending/branch-heads/3029

Project:
chromium

Visibility:
Public.

[Merge M58] Adopt UI review feedback Get rid of colon in Autofill credit card popup suggestions last used date UI string. BUG=698391 TEST=CreditCardTest.GetLastUsedDateForDisplay(components_unittests) Review-Url: https://codereview.chromium.org/2730133003 Cr-Commit-Position: refs/heads/master@{#455533} (cherry picked from commit e5e6dd9b559d0787d8ed20f8c3c45fd4dcbb5f30) Review-Url: https://codereview.chromium.org/2739743003 . Cr-Commit-Position: refs/branch-heads/3029@{#70} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/cc01afb620dc3f47942ca79148371664a1afa604

Created: 3 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+9 lines, -9 lines)			Patch
M	components/autofill/core/browser/credit_card.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	components/autofill/core/browser/credit_card_unittest.cc	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	components/autofill_strings.grdp	View	1 chunk	+4 lines, -4 lines	0 comments	Download

Total messages: 2 (1 generated)

Mathieu

3 years, 9 months ago (2017-03-08 22:25:29 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
cc01afb620dc3f47942ca79148371664a1afa604 (tree was closed).