[Merge M58] Adopt UI review feedback

[Merge M58] Adopt UI review feedback

Get rid of colon in Autofill credit card popup suggestions last used
date UI string.

BUG=698391
TEST=CreditCardTest.GetLastUsedDateForDisplay(components_unittests)

Review-Url: https://codereview.chromium.org/2730133003
Cr-Commit-Position: refs/heads/master@{#455533}
Committed: https://chromium.googlesource.com/chromium/src/+/e5e6dd9b559d0787d8ed20f8c3c45fd4dcbb5f30

[jiahuiguo, 2017-03-03 22:46:00]

The CQ bit was checked by jiahuiguo@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-03-03 22:46:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jiahuiguo, 2017-03-03 23:01:44]

jiahuiguo@google.com changed reviewers:
+ jsaul@google.com, mathp@chromium.org

[jiahuiguo, 2017-03-03 23:01:44]

jiahuiguo@google.com changed required reviewers:
+ mathp@chromium.org

[jiahuiguo, 2017-03-03 23:01:44]

Hi Mathieu and Jared,

PTAL.

[commit-bot: I haz the power, 2017-03-03 23:26:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-03 23:26:01]

Dry run: This issue passed the CQ dry run.

[Jared Saul, 2017-03-03 23:27:09]

https://codereview.chromium.org/2730133003/diff/1/components/autofill_strings...
File components/autofill_strings.grdp (right):

https://codereview.chromium.org/2730133003/diff/1/components/autofill_strings...
components/autofill_strings.grdp:216: Exp <ph
name="EXPIRATION_MONTH">$1<ex>06</ex></ph>/<ph
name="EXPIRATION_YEAR">$2<ex>17</ex></ph>
If I understand
https://codereview.chromium.org/2607043002/diff/400001/components/autofill_st...
correctly, this colon was already here.  Are we actually okay to remove it even
though it's not affected by our experiment?

[jiahuiguo, 2017-03-03 23:52:09]

https://codereview.chromium.org/2730133003/diff/1/components/autofill_strings...
File components/autofill_strings.grdp (right):

https://codereview.chromium.org/2730133003/diff/1/components/autofill_strings...
components/autofill_strings.grdp:216: Exp <ph
name="EXPIRATION_MONTH">$1<ex>06</ex></ph>/<ph
name="EXPIRATION_YEAR">$2<ex>17</ex></ph>
On 2017/03/03 23:27:09, Jared Saul wrote:
> If I understand
>
https://codereview.chromium.org/2607043002/diff/400001/components/autofill_st...
> correctly, this colon was already here.  Are we actually okay to remove it
even
> though it's not affected by our experiment?

Yeah, try to keep them consistent. 
But reverted this change since it is not related to this experiment.

[Jared Saul, 2017-03-04 00:10:14]

On 2017/03/03 23:52:09, jiahuiguo wrote:
>
https://codereview.chromium.org/2730133003/diff/1/components/autofill_strings...
> File components/autofill_strings.grdp (right):
> 
>
https://codereview.chromium.org/2730133003/diff/1/components/autofill_strings...
> components/autofill_strings.grdp:216: Exp <ph
> name="EXPIRATION_MONTH">$1<ex>06</ex></ph>/<ph
> name="EXPIRATION_YEAR">$2<ex>17</ex></ph>
> On 2017/03/03 23:27:09, Jared Saul wrote:
> > If I understand
> >
>
https://codereview.chromium.org/2607043002/diff/400001/components/autofill_st...
> > correctly, this colon was already here.  Are we actually okay to remove it
> even
> > though it's not affected by our experiment?
> 
> Yeah, try to keep them consistent. 
> But reverted this change since it is not related to this experiment.

I certainly understand (and agree about) trying to keep them consistent, I'm
just wary of changing things not related to us.  Maybe ping the person that
discussed getting rid of the colon (was it Alex A.?) and ask them if it's okay
if you remove this colon as well for consistency's sake?

[jiahuiguo, 2017-03-08 18:39:16]

The CQ bit was checked by jiahuiguo@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-03-08 18:40:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jiahuiguo, 2017-03-08 19:09:08]

Hi Mathieu and Jared,

PTAL, this patch removed colon for last used.

It still keeps colon for Expiration date for the sake of consistency with Save
card infobar. Since only last used data without expiration UI is accepted for
Beta, so it doesn't matter at this point.

[Jared Saul, 2017-03-08 19:28:31]

lgtm
Agreed that keeping the colon for expiration is fine for now, because removing
it would be inconsistent with the Upstream dialog and elsewhere (and I think I
heard UX wants to change it to "Expires" anyway instead of "Exp")

[commit-bot: I haz the power, 2017-03-08 19:36:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-08 19:36:10]

Dry run: This issue passed the CQ dry run.

[Mathieu, 2017-03-08 20:34:58]

lgtm

[Mathieu, 2017-03-08 20:35:02]

The CQ bit was checked by mathp@chromium.org

[commit-bot: I haz the power, 2017-03-08 20:35:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-08 20:41:08]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1489005302635360,
"parent_rev": "f9e3cd243761fc60a8bed36b60290c0b8c129fe7", "commit_rev":
"e5e6dd9b559d0787d8ed20f8c3c45fd4dcbb5f30"}

[commit-bot: I haz the power, 2017-03-08 20:41:50]

Description was changed from

==========
[Merge M58] Adopt UI review feedback

Get rid of colon in Autofill credit card popup suggestions last used
date UI string.

BUG=698391
TEST=CreditCardTest.GetLastUsedDateForDisplay(components_unittests)
==========

to

==========
[Merge M58] Adopt UI review feedback

Get rid of colon in Autofill credit card popup suggestions last used
date UI string.

BUG=698391
TEST=CreditCardTest.GetLastUsedDateForDisplay(components_unittests)

Review-Url: https://codereview.chromium.org/2730133003
Cr-Commit-Position: refs/heads/master@{#455533}
Committed:
https://chromium.googlesource.com/chromium/src/+/e5e6dd9b559d0787d8ed20f8c3c4...
==========

[commit-bot: I haz the power, 2017-03-08 20:41:51]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/e5e6dd9b559d0787d8ed20f8c3c4...