[Android] 'Open in new Chrome (incognito) tab under context menu does not work for images and videos

[Android] 'Open in new Chrome (incognito) tab under context menu does not work for images and videos

For links of images and videos, the options 'Open in new Chrome tab'
and 'Open in Chrome incognito tab' under context menu do not work,
because the linkUrl is empty.

To fix this, check whether the link is video or image, if so, pass the
srcUrl instead of linkUrl.

Also for downloaded images and videos, the context menu should be
disabled because current options ('Share' and 'Download image/video')
could be achieved through overflow menu.

To fix this, check if the srcUrl starts with 'file://'.

BUG=696417
NOTRY=true
NOPRESUBMIT=true

Original-Review-Url: https://codereview.chromium.org/2725473002
Cr-Original-Commit-Position: refs/heads/master@{#455181}
(cherry picked from commit 2fc04cd1fea6d3c1fc5d8e1bd5fa2528b2a462d8)

Review-Url: https://codereview.chromium.org/2739723004
Cr-Commit-Position: refs/branch-heads/3029@{#72}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
Committed: https://chromium.googlesource.com/chromium/src/+/498c3d6a3baf0c256a0727bbd6ff910a5fb124f6

[ltian, 2017-03-08 21:45:08]

ltian@chromium.org changed reviewers:
+ dfalcantara@chromium.org

[ltian, 2017-03-08 21:45:08]

dfalcantara@chromium.org: could you lgtm this cl for merging to M58?

Thanks!

[gone, 2017-03-08 21:56:47]

If you can, you should reference the master branch CL in the description for
this CL.

[gone, 2017-03-08 21:56:58]

(but lgtm)

[ltian, 2017-03-08 22:47:23]

Description was changed from

==========
[Android] 'Open in new Chrome (incognito) tab under context menu does not work
for images and videos

For links of images and videos, the options 'Open in new Chrome tab'
and 'Open in Chrome incognito tab' under context menu do not work,
because the linkUrl is empty.

To fix this, check whether the link is video or image, if so, pass the
srcUrl instead of linkUrl.

Also for downloaded images and videos, the context menu should be
disabled because current options ('Share' and 'Download image/video')
could be achieved through overflow menu.

To fix this, check if the srcUrl starts with 'file://'.

BUG=696417
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2725473002
Cr-Commit-Position: refs/heads/master@{#455181}
(cherry picked from commit 2fc04cd1fea6d3c1fc5d8e1bd5fa2528b2a462d8)
==========

to

==========
[Android] 'Open in new Chrome (incognito) tab under context menu does not work
for images and videos

For links of images and videos, the options 'Open in new Chrome tab'
and 'Open in Chrome incognito tab' under context menu do not work,
because the linkUrl is empty.

To fix this, check whether the link is video or image, if so, pass the
srcUrl instead of linkUrl.

Also for downloaded images and videos, the context menu should be
disabled because current options ('Share' and 'Download image/video')
could be achieved through overflow menu.

To fix this, check if the srcUrl starts with 'file://'.

BUG=696417
NOTRY=true
NOPRESUBMIT=true

Original-Review-Url: https://codereview.chromium.org/2725473002
Cr-Original-Commit-Position: refs/heads/master@{#455181}
(cherry picked from commit 2fc04cd1fea6d3c1fc5d8e1bd5fa2528b2a462d8)
==========

[ltian, 2017-03-08 22:48:58]

The CQ bit was checked by ltian@chromium.org

[ltian, 2017-03-08 22:48:58]

The patchset sent to the CQ was uploaded after l-g-t-m from
dfalcantara@chromium.org
Link to the patchset: https://codereview.chromium.org/2739723004/#ps20001
(title: "Clarify the original CL in the description.")

[commit-bot: I haz the power, 2017-03-08 22:49:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-08 22:56:02]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1489013338304600,
"parent_rev": "bff179ffca3cc9e47629a280d8ffd40970bb2b38", "commit_rev":
"498c3d6a3baf0c256a0727bbd6ff910a5fb124f6"}

[commit-bot: I haz the power, 2017-03-08 22:56:43]

Description was changed from

==========
[Android] 'Open in new Chrome (incognito) tab under context menu does not work
for images and videos

For links of images and videos, the options 'Open in new Chrome tab'
and 'Open in Chrome incognito tab' under context menu do not work,
because the linkUrl is empty.

To fix this, check whether the link is video or image, if so, pass the
srcUrl instead of linkUrl.

Also for downloaded images and videos, the context menu should be
disabled because current options ('Share' and 'Download image/video')
could be achieved through overflow menu.

To fix this, check if the srcUrl starts with 'file://'.

BUG=696417
NOTRY=true
NOPRESUBMIT=true

Original-Review-Url: https://codereview.chromium.org/2725473002
Cr-Original-Commit-Position: refs/heads/master@{#455181}
(cherry picked from commit 2fc04cd1fea6d3c1fc5d8e1bd5fa2528b2a462d8)
==========

to

==========
[Android] 'Open in new Chrome (incognito) tab under context menu does not work
for images and videos

For links of images and videos, the options 'Open in new Chrome tab'
and 'Open in Chrome incognito tab' under context menu do not work,
because the linkUrl is empty.

To fix this, check whether the link is video or image, if so, pass the
srcUrl instead of linkUrl.

Also for downloaded images and videos, the context menu should be
disabled because current options ('Share' and 'Download image/video')
could be achieved through overflow menu.

To fix this, check if the srcUrl starts with 'file://'.

BUG=696417
NOTRY=true
NOPRESUBMIT=true

Original-Review-Url: https://codereview.chromium.org/2725473002
Cr-Original-Commit-Position: refs/heads/master@{#455181}
(cherry picked from commit 2fc04cd1fea6d3c1fc5d8e1bd5fa2528b2a462d8)

Review-Url: https://codereview.chromium.org/2739723004
Cr-Commit-Position: refs/branch-heads/3029@{#72}
Cr-Branched-From:
939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
Committed:
https://chromium.googlesource.com/chromium/src/+/498c3d6a3baf0c256a0727bbd6ff...
==========

[commit-bot: I haz the power, 2017-03-08 22:56:44]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/498c3d6a3baf0c256a0727bbd6ff...