[Android] 'Open in new Chrome (incognito) tab under context menu does not work for images and videos

[Android] 'Open in new Chrome (incognito) tab under context menu does not work for images and videos

For links of images and videos, the options 'Open in new Chrome tab'
and 'Open in Chrome incognito tab' under context menu do not work,
because the linkUrl is empty.

To fix this, check whether the link is video or image, if so, pass the
srcUrl instead of linkUrl.

Also for downloaded images and videos, the context menu should be
disabled because current options ('Share' and 'Download image/video')
could be achieved through overflow menu.

To fix this, check if the srcUrl starts with 'file://'.

BUG=696417
Review-Url: https://codereview.chromium.org/2725473002
Cr-Commit-Position: refs/heads/master@{#455181}
Committed: https://chromium.googlesource.com/chromium/src/+/2fc04cd1fea6d3c1fc5d8e1bd5fa2528b2a462d8

[ltian, 2017-02-27 23:01:43]

The CQ bit was checked by ltian@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-27 23:03:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-27 23:55:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-27 23:55:47]

Dry run: This issue passed the CQ dry run.

[ltian, 2017-02-28 00:03:19]

ltian@chromium.org changed reviewers:
+ dfalcantara@chromium.org

[ltian, 2017-02-28 00:03:20]

dfalcantara@chromium.org: could you take a look of my change in this CL?

Thanks!

[gone, 2017-02-28 00:41:04]

dfalcantara@chromium.org changed reviewers:
+ yusufo@chromium.org

[gone, 2017-02-28 00:41:04]

-> Yusuf since he knows the menu code ramifications better than I do.

[Yusuf, 2017-03-06 19:17:52]

https://codereview.chromium.org/2725473002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java
(right):

https://codereview.chromium.org/2725473002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java:437:
private String getUrl(ContextMenuParams params) {
maybe a short comment on why we are treating them differently. Maybe a link to
the bug for more details of context?

https://codereview.chromium.org/2725473002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuParams.java
(right):

https://codereview.chromium.org/2725473002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuParams.java:125:

javadoc and package protected?

[ltian, 2017-03-06 20:22:43]

https://codereview.chromium.org/2725473002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java
(right):

https://codereview.chromium.org/2725473002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java:437:
private String getUrl(ContextMenuParams params) {
On 2017/03/06 19:17:51, Yusuf wrote:
> maybe a short comment on why we are treating them differently. Maybe a link to
> the bug for more details of context?

Done.

https://codereview.chromium.org/2725473002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuParams.java
(right):

https://codereview.chromium.org/2725473002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuParams.java:125:

On 2017/03/06 19:17:51, Yusuf wrote:
> javadoc and package protected?

Done.

[Yusuf, 2017-03-07 00:59:34]

lgtm

[gone, 2017-03-07 04:36:39]

lgtm

[ltian, 2017-03-07 18:50:07]

The CQ bit was checked by ltian@chromium.org

[commit-bot: I haz the power, 2017-03-07 18:51:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-07 19:51:44]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1488912607064530,
"parent_rev": "2744a14dfbc08a2e286aa9d7faab5c465b1910b8", "commit_rev":
"2fc04cd1fea6d3c1fc5d8e1bd5fa2528b2a462d8"}

[commit-bot: I haz the power, 2017-03-07 19:52:29]

Description was changed from

==========
[Android] 'Open in new Chrome (incognito) tab under context menu does not work
for images and videos

For links of images and videos, the options 'Open in new Chrome tab'
and 'Open in Chrome incognito tab' under context menu do not work,
because the linkUrl is empty.

To fix this, check whether the link is video or image, if so, pass the
srcUrl instead of linkUrl.

Also for downloaded images and videos, the context menu should be
disabled because current options ('Share' and 'Download image/video')
could be achieved through overflow menu.

To fix this, check if the srcUrl starts with 'file://'.

BUG=696417
==========

to

==========
[Android] 'Open in new Chrome (incognito) tab under context menu does not work
for images and videos

For links of images and videos, the options 'Open in new Chrome tab'
and 'Open in Chrome incognito tab' under context menu do not work,
because the linkUrl is empty.

To fix this, check whether the link is video or image, if so, pass the
srcUrl instead of linkUrl.

Also for downloaded images and videos, the context menu should be
disabled because current options ('Share' and 'Download image/video')
could be achieved through overflow menu.

To fix this, check if the srcUrl starts with 'file://'.

BUG=696417

Review-Url: https://codereview.chromium.org/2725473002
Cr-Commit-Position: refs/heads/master@{#455181}
Committed:
https://chromium.googlesource.com/chromium/src/+/2fc04cd1fea6d3c1fc5d8e1bd5fa...
==========

[commit-bot: I haz the power, 2017-03-07 19:52:30]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/2fc04cd1fea6d3c1fc5d8e1bd5fa...