Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 2739693002: MD Settings: Close action menu when opening edit cookie exception dialog. (Closed)

Created:
3 years, 9 months ago by dpapad
Modified:
3 years, 9 months ago
Reviewers:
dschuyler
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Close action menu when opening edit cookie exception dialog. BUG=696896 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2739693002 Cr-Commit-Position: refs/heads/master@{#455253} Committed: https://chromium.googlesource.com/chromium/src/+/d9070600ab8f23e9f7d7dc468173157388d56769

Patch Set 1 #

Patch Set 2 : Add test assertion. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M chrome/browser/resources/settings/site_settings/site_list.js View 1 chunk +5 lines, -3 lines 0 comments Download
M chrome/test/data/webui/settings/site_list_tests.js View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
dpapad
Screenshots at http://imgur.com/a/EjwyL
3 years, 9 months ago (2017-03-07 19:59:12 UTC) #5
dschuyler
lgtm
3 years, 9 months ago (2017-03-07 22:04:10 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2739693002/20001
3 years, 9 months ago (2017-03-07 22:06:55 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-07 22:26:44 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/d9070600ab8f23e9f7d7dc468173...

Powered by Google App Engine
This is Rietveld 408576698