Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3532)

Unified Diff: chrome/browser/resources/settings/site_settings/site_list.js

Issue 2739693002: MD Settings: Close action menu when opening edit cookie exception dialog. (Closed)
Patch Set: Add test assertion. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/test/data/webui/settings/site_list_tests.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/settings/site_settings/site_list.js
diff --git a/chrome/browser/resources/settings/site_settings/site_list.js b/chrome/browser/resources/settings/site_settings/site_list.js
index ed7a2b3747cc90c0ec4fde6b4737080f29ed49c3..86bbc03ecf8d90945a71ab204f81c0191aa7eb86 100644
--- a/chrome/browser/resources/settings/site_settings/site_list.js
+++ b/chrome/browser/resources/settings/site_settings/site_list.js
@@ -449,15 +449,17 @@ Polymer({
/** @private */
onEditTap_: function() {
+ // Close action menu without resetting |this.actionMenuSite_| since it is
+ // bound to the dialog.
+ /** @type {!CrActionMenuElement} */ (
+ this.$$('dialog[is=cr-action-menu]')).close();
this.showEditExceptionDialog_ = true;
},
/** @private */
onEditExceptionDialogClosed_: function() {
this.showEditExceptionDialog_ = false;
- // Close action menu after dialog has been closed, otherwise
- // |actionMenuSite_| is reset while the dialog is still accessing it.
- this.closeActionMenu_();
+ this.actionMenuSite_ = null;
},
/** @private */
« no previous file with comments | « no previous file | chrome/test/data/webui/settings/site_list_tests.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698