Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(545)

Issue 2739683003: Skip updating jumplist icons if creation of folder JumplistIcons fails (Closed)

Created:
3 years, 9 months ago by chengx
Modified:
3 years, 9 months ago
Reviewers:
grt (UTC plus 2)
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Skip updating jumplist icons if creation of folder JumplistIcons fails According to UMA, 0.14% of jumplist IO operations fail to create folder JumplistIcons after its successful deletion for unknown reasons. This could impact roughly 0.14% Chrome users. In this case, updating jumplist icons is meaningless and should be skipped. BUG=40407, 179576 Review-Url: https://codereview.chromium.org/2739683003 Cr-Commit-Position: refs/heads/master@{#455489} Committed: https://chromium.googlesource.com/chromium/src/+/051b0af2835a602463b2960894f296f3dcc22680

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M chrome/browser/win/jumplist.cc View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 16 (11 generated)
chengx
PTAL~
3 years, 9 months ago (2017-03-07 18:49:54 UTC) #6
chengx
Hi grt@, it seems I used your corp email rather than chromium email by mistake. ...
3 years, 9 months ago (2017-03-07 21:27:30 UTC) #10
grt (UTC plus 2)
lgtm
3 years, 9 months ago (2017-03-08 09:05:04 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2739683003/1
3 years, 9 months ago (2017-03-08 17:54:57 UTC) #13
commit-bot: I haz the power
3 years, 9 months ago (2017-03-08 18:01:18 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/051b0af2835a602463b2960894f2...

Powered by Google App Engine
This is Rietveld 408576698