Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8687)

Unified Diff: chrome/browser/win/jumplist.cc

Issue 2739683003: Skip updating jumplist icons if creation of folder JumplistIcons fails (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/win/jumplist.cc
diff --git a/chrome/browser/win/jumplist.cc b/chrome/browser/win/jumplist.cc
index 3c114eeab9aa26465d4946a0390a3ba229b22062..c6d518a91bccc2a199d1ed4ca4b291c73e3ea803 100644
--- a/chrome/browser/win/jumplist.cc
+++ b/chrome/browser/win/jumplist.cc
@@ -296,8 +296,11 @@ void RunUpdateOnFileThread(
}
}
- if (!base::CreateDirectory(icon_dir))
+ // If CreateDirectory() fails, exit early.
+ if (!base::CreateDirectory(icon_dir)) {
folder_operation_status |= FolderOperationResult::CREATE_SRC_FAILED;
+ return;
+ }
// Create temporary icon files for shortcuts in the "Most Visited" category.
CreateIconFiles(icon_dir, local_most_visited_pages);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698