Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2739553002:
Fix comment on how to normalize the Omnibox.AnswerParseType histogram. (Closed)
|
Created:
3 years, 9 months ago by Justin Donnelly Modified:
3 years, 9 months ago Reviewers:
Mark P CC:
chromium-reviews, asvitkine+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionFix comment on how to normalize the Omnibox.AnswerParseType histogram.
See discussion on https://codereview.chromium.org/2728663005/ where the histogram was originally added.
BUG=591803
Review-Url: https://codereview.chromium.org/2739553002
Cr-Commit-Position: refs/heads/master@{#455139}
Committed: https://chromium.googlesource.com/chromium/src/+/545222f357e150eec7c10740b2f752cc2b30a215
Patch Set 1 #
Total comments: 2
Patch Set 2 : Add note about failure cases. #Messages
Total messages: 19 (14 generated)
The CQ bit was checked by jdonnelly@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Fix comment on how to normalize the Omnibox.AnswerParseType histogram. BUG=591803 ========== to ========== Fix comment on how to normalize the Omnibox.AnswerParseType histogram. See discussion on https://codereview.chromium.org/2728663005/ where the histogram was originally added. BUG=591803 ==========
jdonnelly@chromium.org changed reviewers: + mpearson@chromium.org
lgtm with one minor nit (you forgot something we talked about) --mark https://codereview.chromium.org/2739553002/diff/1/tools/metrics/histograms/hi... File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/2739553002/diff/1/tools/metrics/histograms/hi... tools/metrics/histograms/histograms.xml:43545: + with answers attached. minor nit: > And point out that we're off under those > conditions [successful requests fail to parse] (extract, deserialize, and parse), but that's normally not a > problem because the error is probably pretty small (or non-existent)--we > trust our servers.
The CQ bit was checked by jdonnelly@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by jdonnelly@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2739553002/diff/1/tools/metrics/histograms/hi... File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/2739553002/diff/1/tools/metrics/histograms/hi... tools/metrics/histograms/histograms.xml:43545: + with answers attached. On 2017/03/07 00:53:22, Mark P wrote: > minor nit: > > And point out that we're off under those > > conditions [successful requests fail to parse] (extract, deserialize, and > parse), but that's normally not a > > problem because the error is probably pretty small (or non-existent)--we > > trust our servers. Done.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by jdonnelly@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from mpearson@chromium.org Link to the patchset: https://codereview.chromium.org/2739553002/#ps20001 (title: "Add note about failure cases.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1488905150224300,
"parent_rev": "6fef8c766b8554fa835a1fb4c120e771d4055f51", "commit_rev":
"545222f357e150eec7c10740b2f752cc2b30a215"}
Message was sent while issue was closed.
Description was changed from ========== Fix comment on how to normalize the Omnibox.AnswerParseType histogram. See discussion on https://codereview.chromium.org/2728663005/ where the histogram was originally added. BUG=591803 ========== to ========== Fix comment on how to normalize the Omnibox.AnswerParseType histogram. See discussion on https://codereview.chromium.org/2728663005/ where the histogram was originally added. BUG=591803 Review-Url: https://codereview.chromium.org/2739553002 Cr-Commit-Position: refs/heads/master@{#455139} Committed: https://chromium.googlesource.com/chromium/src/+/545222f357e150eec7c10740b2f7... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/545222f357e150eec7c10740b2f7... |
