Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tools/metrics/histograms/histograms.xml

Issue 2739553002: Fix comment on how to normalize the Omnibox.AnswerParseType histogram. (Closed)
Patch Set: Add note about failure cases. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 262ca22a17dafdaaf988794fe64d9b93b08ab987..c1bec46a134988f8fb13ca1ab2710bfc95b93b42 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -43540,7 +43540,11 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
<summary>
The number of times each omnibox suggestion answer type (e.g., weather,
sports score) was received and parsed successfully. Can be normalized with
- Omnibox.AnswerParseSuccess.
+ the count of emits to Omnibox.SuggestRequest.Success.GoogleResponseTime,
+ which counts all successful suggest responses from Google, not just those
+ with answers attached. Note that GoogleResponseTime is technically off given
+ that it will still count cases where we fail to extract, deserialize, or
+ parse the response. But these cases are rare to non-existent.
</summary>
</histogram>
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698