Better detect options for Brother CUPS printers.

Better detect options for Brother CUPS printers.

BUG=415286
Review-Url: https://codereview.chromium.org/2739133002
Cr-Commit-Position: refs/heads/master@{#456266}
Committed: https://chromium.googlesource.com/chromium/src/+/1847e48dd7820b047ec19c03b7c1ae2fbc74eda1

[Lei Zhang, 2017-03-09 10:42:35]

The CQ bit was checked by thestig@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-09 10:42:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-09 11:12:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-09 11:12:10]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Lei Zhang, 2017-03-09 11:52:30]

The CQ bit was checked by thestig@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-09 11:52:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-09 13:06:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-09 13:06:12]

Dry run: This issue passed the CQ dry run.

[Lei Zhang, 2017-03-09 21:44:32]

The CQ bit was checked by thestig@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-09 21:44:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Lei Zhang, 2017-03-09 21:46:59]

thestig@chromium.org changed reviewers:
+ rbpotter@chromium.org, skau@chromium.org

[commit-bot: I haz the power, 2017-03-09 23:28:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-09 23:28:27]

Dry run: This issue passed the CQ dry run.

[skau, 2017-03-10 21:42:41]

lgtm

Looks like you also fixed how duplex is interpreted.  Do we need to updated the
UI?  I'm not sure it recognizes SHORT_EDGE right now.

[Lei Zhang, 2017-03-10 22:57:14]

On 2017/03/10 21:42:41, skau wrote:
> lgtm
> 
> Looks like you also fixed how duplex is interpreted.  Do we need to updated
the
> UI?  I'm not sure it recognizes SHORT_EDGE right now.

The print preview UI does not support short edge. It's a checkbox that toggles
long edge duplex and simplex. There's a bug to surface short edge duplex.

I tried hard coding GetDuplexSettings() to return SHORT_EDGE as the default, and
print preview still correctly picked LONG_EDGE when the checkbox is checked.

[Lei Zhang, 2017-03-10 23:15:44]

The CQ bit was checked by thestig@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-10 23:16:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Lei Zhang, 2017-03-10 23:23:00]

I found a few more places where we didn't handle the BROTHER_COLOR_* enums. See
patch set 5. I don't have a color Brother printer handy, so I cannot actually
verify I'm setting the right color values. We may need to work with the bug
reporter and do a follow up CL if needed.

[commit-bot: I haz the power, 2017-03-11 00:04:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-11 00:04:18]

Dry run: This issue passed the CQ dry run.

[Lei Zhang, 2017-03-11 02:54:01]

Let's get this in and see what happens.

[Lei Zhang, 2017-03-11 02:54:05]

The CQ bit was checked by thestig@chromium.org

[Lei Zhang, 2017-03-11 02:54:06]

The patchset sent to the CQ was uploaded after l-g-t-m from skau@chromium.org
Link to the patchset: https://codereview.chromium.org/2739133002/#ps80001
(title: "Fix more color checks")

[commit-bot: I haz the power, 2017-03-11 02:54:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-11 02:58:34]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1489200845808820,
"parent_rev": "82c89156820e06f1586edd0cc3850e7a5450921c", "commit_rev":
"1847e48dd7820b047ec19c03b7c1ae2fbc74eda1"}

[commit-bot: I haz the power, 2017-03-11 02:59:17]

Description was changed from

==========
Better detect options for Brother CUPS printers.

BUG=415286
==========

to

==========
Better detect options for Brother CUPS printers.

BUG=415286

Review-Url: https://codereview.chromium.org/2739133002
Cr-Commit-Position: refs/heads/master@{#456266}
Committed:
https://chromium.googlesource.com/chromium/src/+/1847e48dd7820b047ec19c03b7c1...
==========

[commit-bot: I haz the power, 2017-03-11 02:59:18]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/1847e48dd7820b047ec19c03b7c1...