Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Unified Diff: printing/backend/cups_helper_unittest.cc

Issue 2739133002: Better detect options for Brother CUPS printers. (Closed)
Patch Set: Fix more color checks Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « printing/backend/cups_helper.cc ('k') | printing/print_job_constants.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: printing/backend/cups_helper_unittest.cc
diff --git a/printing/backend/cups_helper_unittest.cc b/printing/backend/cups_helper_unittest.cc
index 7daa1ca8afab4bd47072574ae1e96f401c978694..1acd900e729d1ecd6ec2cd98fa2a87613891abad 100644
--- a/printing/backend/cups_helper_unittest.cc
+++ b/printing/backend/cups_helper_unittest.cc
@@ -6,7 +6,7 @@
#include "printing/backend/print_backend.h"
#include "testing/gtest/include/gtest/gtest.h"
-TEST(PrintBackendCupsHelperTest, TestPpdParsingNoColorDuplexLongEdge) {
+TEST(PrintBackendCupsHelperTest, TestPpdParsingNoColorDuplexShortEdge) {
const char kTestPpdData[] =
"*PPD-Adobe: \"4.3\"\n\n"
"*OpenGroup: General/General\n\n"
@@ -36,7 +36,7 @@ TEST(PrintBackendCupsHelperTest, TestPpdParsingNoColorDuplexLongEdge) {
EXPECT_TRUE(caps.collate_default);
EXPECT_TRUE(caps.copies_capable);
EXPECT_TRUE(caps.duplex_capable);
- EXPECT_EQ(printing::LONG_EDGE, caps.duplex_default);
+ EXPECT_EQ(printing::SHORT_EDGE, caps.duplex_default);
EXPECT_FALSE(caps.color_changeable);
EXPECT_FALSE(caps.color_default);
}
@@ -94,7 +94,7 @@ TEST(PrintBackendCupsHelperTest, TestPpdParsingNoColorNoDuplex) {
EXPECT_FALSE(caps.color_default);
}
-TEST(PrintBackendCupsHelperTest, TestPpdParsingColorTrueDuplexLongEdge) {
+TEST(PrintBackendCupsHelperTest, TestPpdParsingColorTrueDuplexShortEdge) {
const char kTestPpdData[] =
"*PPD-Adobe: \"4.3\"\n\n"
"*ColorDevice: True\n"
@@ -124,7 +124,7 @@ TEST(PrintBackendCupsHelperTest, TestPpdParsingColorTrueDuplexLongEdge) {
EXPECT_TRUE(caps.collate_default);
EXPECT_TRUE(caps.copies_capable);
EXPECT_TRUE(caps.duplex_capable);
- EXPECT_EQ(printing::LONG_EDGE, caps.duplex_default);
+ EXPECT_EQ(printing::SHORT_EDGE, caps.duplex_default);
EXPECT_TRUE(caps.color_changeable);
EXPECT_TRUE(caps.color_default);
}
@@ -147,7 +147,7 @@ TEST(PrintBackendCupsHelperTest, TestPpdParsingColorFalseDuplexLongEdge) {
"\"JCLDatamode=Grayscale GSCmdLine=Grayscale\"\n"
"*CloseUI: *ColorModel\n"
"*OpenUI *Duplex/2-Sided Printing: PickOne\n"
- "*DefaultDuplex: DuplexTumble\n"
+ "*DefaultDuplex: DuplexNoTumble\n"
"*Duplex None/Off: \"<</Duplex false>>"
"setpagedevice\"\n"
"*Duplex DuplexNoTumble/LongEdge: \""
@@ -199,3 +199,59 @@ TEST(PrintBackendCupsHelperTest, TestPpdParsingPageSize) {
EXPECT_EQ(215900, caps.papers[1].size_um.width());
EXPECT_EQ(355600, caps.papers[1].size_um.height());
}
+
+TEST(PrintBackendCupsHelperTest, TestPpdParsingBrotherPrinters) {
+ {
+ const char kTestPpdData[] =
+ "*PPD-Adobe: \"4.3\"\n\n"
+ "*ColorDevice: True\n"
+ "*OpenUI *BRPrintQuality/Color/Mono: PickOne\n"
+ "*DefaultBRPrintQuality: Auto\n"
+ "*BRPrintQuality Auto/Auto: \"\"\n"
+ "*BRPrintQuality Color/Color: \"\"\n"
+ "*BRPrintQuality Black/Mono: \"\"\n"
+ "*CloseUI: *BRPrintQuality\n\n";
+
+ printing::PrinterSemanticCapsAndDefaults caps;
+ EXPECT_TRUE(printing::ParsePpdCapabilities("test", kTestPpdData, &caps));
+ EXPECT_TRUE(caps.color_changeable);
+ EXPECT_TRUE(caps.color_default);
+ EXPECT_EQ(printing::BROTHER_COLOR_COLOR, caps.color_model);
+ EXPECT_EQ(printing::BROTHER_COLOR_BLACK, caps.bw_model);
+ }
+ {
+ const char kTestPpdData[] =
+ "*PPD-Adobe: \"4.3\"\n\n"
+ "*ColorDevice: True\n"
+ "*OpenUI *BRMonoColor/Color / Mono: PickOne\n"
+ "*DefaultBRMonoColor: Auto\n"
+ "*BRMonoColor Auto/Auto: \"\"\n"
+ "*BRMonoColor FullColor/Color: \"\"\n"
+ "*BRMonoColor Mono/Mono: \"\"\n"
+ "*CloseUI: *BRMonoColor\n\n";
+
+ printing::PrinterSemanticCapsAndDefaults caps;
+ EXPECT_TRUE(printing::ParsePpdCapabilities("test", kTestPpdData, &caps));
+ EXPECT_TRUE(caps.color_changeable);
+ EXPECT_TRUE(caps.color_default);
+ EXPECT_EQ(printing::BROTHER_COLOR_COLOR, caps.color_model);
+ EXPECT_EQ(printing::BROTHER_COLOR_BLACK, caps.bw_model);
+ }
+ {
+ const char kTestPpdData[] =
+ "*PPD-Adobe: \"4.3\"\n\n"
+ "*ColorDevice: True\n"
+ "*OpenUI *BRDuplex/Two-Sided Printing: PickOne\n"
+ "*OrderDependency: 25 AnySetup *BRDuplex\n"
+ "*DefaultBRDuplex: DuplexTumble\n"
+ "*BRDuplex DuplexTumble/Short-Edge Binding: \"\"\n"
+ "*BRDuplex DuplexNoTumble/Long-Edge Binding: \"\"\n"
+ "*BRDuplex None/Off: \"\"\n"
+ "*CloseUI: *BRDuplex\n\n";
+
+ printing::PrinterSemanticCapsAndDefaults caps;
+ EXPECT_TRUE(printing::ParsePpdCapabilities("test", kTestPpdData, &caps));
+ EXPECT_TRUE(caps.duplex_capable);
+ EXPECT_EQ(printing::SHORT_EDGE, caps.duplex_default);
+ }
+}
« no previous file with comments | « printing/backend/cups_helper.cc ('k') | printing/print_job_constants.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698