Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1505)

Issue 2739083004: Revert of Make download item drags look like bookmark drags. (Closed)

Created:
3 years, 9 months ago by msw
Modified:
3 years, 9 months ago
Reviewers:
sky, Evan Stade
CC:
chromium-reviews, asanka, dcheng
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Make download item drags look like bookmark drags. (patchset #1 id:1 of https://codereview.chromium.org/2740433005/ ) Reason for revert: http://crbug.com/700161 Original issue's description: > Make download item drags look like bookmark drags. > > As discussed in https://codereview.chromium.org/2654853002/ > > BUG=624175 > > Review-Url: https://codereview.chromium.org/2740433005 > Cr-Commit-Position: refs/heads/master@{#455507} > Committed: https://chromium.googlesource.com/chromium/src/+/4e4eae4cbe6136b538a3ea8297b07ef365d06337 TBR=sky@chromium.org,estade@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=624175 Review-Url: https://codereview.chromium.org/2739083004 Cr-Commit-Position: refs/heads/master@{#455909} Committed: https://chromium.googlesource.com/chromium/src/+/816c1c01dce669bd39ab3c3f769a9af8ee7a7e05

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -6 lines) Patch
M chrome/browser/download/drag_download_item_views.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M ui/base/dragdrop/drag_utils.h View 1 chunk +9 lines, -0 lines 0 comments Download
M ui/base/dragdrop/drag_utils.cc View 1 chunk +87 lines, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
msw
Created Revert of Make download item drags look like bookmark drags.
3 years, 9 months ago (2017-03-09 22:13:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2739083004/1
3 years, 9 months ago (2017-03-09 22:14:14 UTC) #3
commit-bot: I haz the power
3 years, 9 months ago (2017-03-09 23:56:06 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/816c1c01dce669bd39ab3c3f769a...

Powered by Google App Engine
This is Rietveld 408576698