Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 2740433005: Make download item drags look like bookmark drags. (Closed)

Created:
3 years, 9 months ago by Evan Stade
Modified:
3 years, 9 months ago
Reviewers:
msw, sky
CC:
chromium-reviews, asanka, dcheng
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make download item drags look like bookmark drags. As discussed in https://codereview.chromium.org/2654853002/ BUG=624175 Review-Url: https://codereview.chromium.org/2740433005 Cr-Commit-Position: refs/heads/master@{#455507} Committed: https://chromium.googlesource.com/chromium/src/+/4e4eae4cbe6136b538a3ea8297b07ef365d06337

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -101 lines) Patch
M chrome/browser/download/drag_download_item_views.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M ui/base/dragdrop/drag_utils.h View 1 chunk +0 lines, -9 lines 0 comments Download
M ui/base/dragdrop/drag_utils.cc View 1 chunk +1 line, -87 lines 2 comments Download

Messages

Total messages: 21 (11 generated)
Evan Stade
sorry it took me a while to come back to this.
3 years, 9 months ago (2017-03-08 02:31:03 UTC) #4
msw
lgtm
3 years, 9 months ago (2017-03-08 16:25:21 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2740433005/1
3 years, 9 months ago (2017-03-08 17:26:45 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/381024)
3 years, 9 months ago (2017-03-08 17:33:38 UTC) #11
Evan Stade
+sky as OWNER
3 years, 9 months ago (2017-03-08 18:29:46 UTC) #13
sky
LGTM https://codereview.chromium.org/2740433005/diff/1/ui/base/dragdrop/drag_utils.cc File ui/base/dragdrop/drag_utils.cc (left): https://codereview.chromium.org/2740433005/diff/1/ui/base/dragdrop/drag_utils.cc#oldcode57 ui/base/dragdrop/drag_utils.cc:57: canvas->DrawStringRectWithHalo(name, font_list, kFileDragImageTextColor, I think you can get ...
3 years, 9 months ago (2017-03-08 18:48:31 UTC) #14
Evan Stade
https://codereview.chromium.org/2740433005/diff/1/ui/base/dragdrop/drag_utils.cc File ui/base/dragdrop/drag_utils.cc (left): https://codereview.chromium.org/2740433005/diff/1/ui/base/dragdrop/drag_utils.cc#oldcode57 ui/base/dragdrop/drag_utils.cc:57: canvas->DrawStringRectWithHalo(name, font_list, kFileDragImageTextColor, On 2017/03/08 18:48:30, sky wrote: > ...
3 years, 9 months ago (2017-03-08 18:56:54 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2740433005/1
3 years, 9 months ago (2017-03-08 18:57:56 UTC) #17
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/4e4eae4cbe6136b538a3ea8297b07ef365d06337
3 years, 9 months ago (2017-03-08 19:05:20 UTC) #20
msw
3 years, 9 months ago (2017-03-09 22:13:40 UTC) #21
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2739083004/ by msw@chromium.org.

The reason for reverting is: http://crbug.com/700161.

Powered by Google App Engine
This is Rietveld 408576698