Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 2739073002: cros: Use ScreenManager as a component instead of deriving WizardController from it (Closed)

Created:
3 years, 9 months ago by jdufault
Modified:
3 years, 9 months ago
Reviewers:
Alexander Alekseev
CC:
chromium-reviews, pam+watch_chromium.org, alemate+watch_chromium.org, achuith+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cros: Use ScreenManager as a component instead of deriving WizardController from it This makes it easier/cleaner to implement CoreOobeView::Delegate on ScreenManager in a follow-up CL. BUG=672142 Review-Url: https://codereview.chromium.org/2739073002 Cr-Commit-Position: refs/heads/master@{#456228} Committed: https://chromium.googlesource.com/chromium/src/+/3ceda53488f7cc8d72734247c6a5e11422c40ede

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Patch Set 4 : Address comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -70 lines) Patch
M chrome/browser/chromeos/login/enrollment/enrollment_screen_browsertest.cc View 7 chunks +14 lines, -13 lines 0 comments Download
M chrome/browser/chromeos/login/enterprise_enrollment_browsertest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/oobe_localization_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/screen_manager.h View 1 2 3 2 chunks +12 lines, -9 lines 0 comments Download
M chrome/browser/chromeos/login/screen_manager.cc View 1 2 3 1 chunk +8 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/login/screens/network_screen_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/screens/update_screen_browsertest.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/supervised/supervised_user_creation_flow.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/users/avatar/user_image_sync_observer.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/wizard_controller.h View 1 2 3 3 chunks +11 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/wizard_controller.cc View 1 2 3 10 chunks +15 lines, -10 lines 0 comments Download
M chrome/browser/chromeos/login/wizard_controller_browsertest.cc View 6 chunks +22 lines, -17 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 18 (13 generated)
jdufault
alemate@ PTAL
3 years, 9 months ago (2017-03-09 19:28:50 UTC) #7
jdufault
Addressed comments discussed offline.
3 years, 9 months ago (2017-03-10 23:59:02 UTC) #10
Alexander Alekseev
lgtm
3 years, 9 months ago (2017-03-11 00:16:44 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2739073002/60001
3 years, 9 months ago (2017-03-11 00:18:47 UTC) #15
commit-bot: I haz the power
3 years, 9 months ago (2017-03-11 00:24:57 UTC) #18
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/3ceda53488f7cc8d72734247c6a5...

Powered by Google App Engine
This is Rietveld 408576698