Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2738973003: cros: WIP patch to remove EnableDebuggingScreenView

Created:
3 years, 9 months ago by jdufault
Modified:
3 years, 9 months ago
Reviewers:
CC:
chromium-reviews, alemate+watch_chromium.org, achuith+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cros: WIP patch to remove EnableDebuggingScreenView BUG=

Patch Set 1 #

Patch Set 2 : Initial upload #

Patch Set 3 : Initial upload #

Patch Set 4 : Initial upload #

Unified diffs Side-by-side diffs Delta from patch set Stats (+528 lines, -178 lines) Patch
M chrome/browser/chromeos/BUILD.gn View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/screen_manager.h View 1 2 3 2 chunks +19 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/screen_manager.cc View 1 2 3 1 chunk +14 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/screens/core_oobe_view.h View 1 2 3 2 chunks +57 lines, -22 lines 0 comments Download
A chrome/browser/chromeos/login/screens/core_oobe_view.cc View 1 2 3 1 chunk +70 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/screens/enable_debugging_screen.h View 1 chunk +10 lines, -9 lines 0 comments Download
M chrome/browser/chromeos/login/screens/enable_debugging_screen.cc View 1 1 chunk +11 lines, -17 lines 0 comments Download
D chrome/browser/chromeos/login/screens/enable_debugging_screen_view.h View 1 chunk +0 lines, -42 lines 0 comments Download
A chrome/browser/chromeos/login/screens/mock_core_oobe_view.h View 1 chunk +57 lines, -0 lines 0 comments Download
A + chrome/browser/chromeos/login/screens/mock_core_oobe_view.cc View 1 chunk +3 lines, -12 lines 0 comments Download
M chrome/browser/chromeos/login/screens/mock_enable_debugging_screen.h View 2 chunks +2 lines, -17 lines 0 comments Download
M chrome/browser/chromeos/login/screens/mock_enable_debugging_screen.cc View 1 chunk +1 line, -19 lines 0 comments Download
M chrome/browser/chromeos/login/wizard_controller.cc View 1 2 3 3 chunks +12 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/wizard_controller_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/BUILD.gn View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/enable_debugging_screen_handler.h View 1 chunk +9 lines, -6 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/enable_debugging_screen_handler.cc View 4 chunks +17 lines, -11 lines 0 comments Download
A chrome/browser/ui/webui/chromeos/login/multicast_core_oobe_view.h View 1 chunk +66 lines, -0 lines 0 comments Download
A chrome/browser/ui/webui/chromeos/login/multicast_core_oobe_view.cc View 1 1 chunk +152 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/oobe_ui.h View 1 4 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/oobe_ui.cc View 10 chunks +16 lines, -13 lines 0 comments Download
M chrome/test/BUILD.gn View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download

Depends on Patchset:

Issue 2739073002 Patch 60001

Dependent Patchsets:

Messages

Total messages: 16 (16 generated)
jdufault
The CQ bit was checked by jdufault@chromium.org to run a CQ dry run
3 years, 9 months ago (2017-03-09 02:12:35 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2738973003/1
3 years, 9 months ago (2017-03-09 02:13:07 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 9 months ago (2017-03-09 02:56:42 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/325361) linux_chromium_chromeos_rel_ng on ...
3 years, 9 months ago (2017-03-09 02:56:43 UTC) #4
jdufault
The CQ bit was checked by jdufault@chromium.org to run a CQ dry run
3 years, 9 months ago (2017-03-09 22:05:29 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2738973003/20001
3 years, 9 months ago (2017-03-09 22:06:03 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 9 months ago (2017-03-09 23:03:30 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/337561)
3 years, 9 months ago (2017-03-09 23:03:31 UTC) #8
jdufault
The CQ bit was checked by jdufault@chromium.org to run a CQ dry run
3 years, 9 months ago (2017-03-10 18:28:34 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2738973003/40001
3 years, 9 months ago (2017-03-10 18:28:57 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 9 months ago (2017-03-10 19:55:41 UTC) #11
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/381178)
3 years, 9 months ago (2017-03-10 19:55:42 UTC) #12
jdufault
The CQ bit was checked by jdufault@chromium.org to run a CQ dry run
3 years, 9 months ago (2017-03-10 23:45:27 UTC) #13
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2738973003/60001
3 years, 9 months ago (2017-03-10 23:45:56 UTC) #14
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 9 months ago (2017-03-11 01:18:09 UTC) #15
commit-bot: I haz the power
3 years, 9 months ago (2017-03-11 01:18:10 UTC) #16 
Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

Powered by Google App Engine
This is Rietveld 408576698