Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 2739023003: Make adjustedSelectionStartForStyleComputation() to take Position instead of VisibleSeleciton (Closed)

Created:
3 years, 9 months ago by yosin_UTC9
Modified:
3 years, 9 months ago
Reviewers:
tkent, yoichio, Xiaocheng
CC:
blink-reviews, blink-reviews-style_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make adjustedSelectionStartForStyleComputation() to take Position instead of VisibleSeleciton This patch makes |adjustedSelectionStartForStyleComputation()| to take |Position| instead of |VisibleSeleciton| as a preparation of usage of |VisibleSeleciton| for improving code health. BUG=657237 TEST=n/a; no behavior changes Review-Url: https://codereview.chromium.org/2739023003 Cr-Commit-Position: refs/heads/master@{#455945} Committed: https://chromium.googlesource.com/chromium/src/+/18f9f5a5e63781235137f0b90636b5fd174cb64f

Patch Set 1 : 2017-03-09T15:23:37 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -10 lines) Patch
M third_party/WebKit/Source/core/editing/EditingStyleUtilities.cpp View 1 chunk +6 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/EditingUtilities.h View 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/EditingUtilities.cpp View 1 chunk +2 lines, -8 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
yosin_UTC9
PTAL
3 years, 9 months ago (2017-03-09 07:46:26 UTC) #6
Xiaocheng
lgtm
3 years, 9 months ago (2017-03-09 19:12:02 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2739023003/1
3 years, 9 months ago (2017-03-10 00:48:43 UTC) #11
commit-bot: I haz the power
3 years, 9 months ago (2017-03-10 01:24:00 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/18f9f5a5e63781235137f0b90636...

Powered by Google App Engine
This is Rietveld 408576698