Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: third_party/WebKit/Source/core/editing/EditingUtilities.h

Issue 2739023003: Make adjustedSelectionStartForStyleComputation() to take Position instead of VisibleSeleciton (Closed)
Patch Set: 2017-03-09T15:23:37 Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2006, 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2004, 2006, 2008 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 367 matching lines...) Expand 10 before | Expand all | Expand 10 after
378 378
379 bool canMergeLists(Element* firstList, Element* secondList); 379 bool canMergeLists(Element* firstList, Element* secondList);
380 380
381 // ------------------------------------------------------------------------- 381 // -------------------------------------------------------------------------
382 // VisibleSelection 382 // VisibleSelection
383 // ------------------------------------------------------------------------- 383 // -------------------------------------------------------------------------
384 384
385 // Functions returning VisibleSelection 385 // Functions returning VisibleSelection
386 VisibleSelection selectionForParagraphIteration(const VisibleSelection&); 386 VisibleSelection selectionForParagraphIteration(const VisibleSelection&);
387 387
388 Position adjustedSelectionStartForStyleComputation(const VisibleSelection&); 388 // TODO(editing-dev): We should move "adjustedSelectionStartForStyleComputation"
389 // to "EditingStyleUtilitie.cpp" as local function since it used only there.
390 Position adjustedSelectionStartForStyleComputation(const Position&);
389 391
390 // Miscellaneous functions on Text 392 // Miscellaneous functions on Text
391 inline bool isWhitespace(UChar c) { 393 inline bool isWhitespace(UChar c) {
392 return c == noBreakSpaceCharacter || c == ' ' || c == '\n' || c == '\t'; 394 return c == noBreakSpaceCharacter || c == ' ' || c == '\n' || c == '\t';
393 } 395 }
394 396
395 // FIXME: Can't really answer this question correctly without knowing the 397 // FIXME: Can't really answer this question correctly without knowing the
396 // white-space mode. 398 // white-space mode.
397 inline bool isCollapsibleWhitespace(UChar c) { 399 inline bool isCollapsibleWhitespace(UChar c) {
398 return c == ' ' || c == '\n'; 400 return c == ' ' || c == '\n';
(...skipping 28 matching lines...) Expand all
427 DispatchEventResult dispatchBeforeInputDataTransfer(Node*, 429 DispatchEventResult dispatchBeforeInputDataTransfer(Node*,
428 InputEvent::InputType, 430 InputEvent::InputType,
429 DataTransfer*); 431 DataTransfer*);
430 432
431 InputEvent::InputType deletionInputTypeFromTextGranularity(DeleteDirection, 433 InputEvent::InputType deletionInputTypeFromTextGranularity(DeleteDirection,
432 TextGranularity); 434 TextGranularity);
433 435
434 } // namespace blink 436 } // namespace blink
435 437
436 #endif 438 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698