Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issue 2738983004: Set an initial background for RenderFrameHosts during commit. (Closed)

Created:
3 years, 9 months ago by chrishtr
Modified:
3 years, 9 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

Set an initial background for RenderFrameHosts during commit. This was originally implemented in https://codereview.chromium.org/2466413009, but was broken by https://codereview.chromium.org/2496233003. Now re-adding with more explicit code, plus a unittest. BUG=470669 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2733093002 Cr-Commit-Position: refs/heads/master@{#455612} (cherry picked from commit 5f3c1abd7dc2df3024315ec66eb46e89a5e146c8) Review-Url: https://codereview.chromium.org/2738983004 . Cr-Commit-Position: refs/branch-heads/3029@{#95} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/68d43f9c021c6259b25a0594d7a0d1a1505ee0dc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -12 lines) Patch
M content/browser/frame_host/render_frame_host_manager.cc View 2 chunks +12 lines, -0 lines 0 comments Download
M content/browser/frame_host/render_frame_host_manager_unittest.cc View 3 chunks +8 lines, -0 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 chunk +0 lines, -12 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
chrishtr
3 years, 9 months ago (2017-03-09 22:45:35 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
68d43f9c021c6259b25a0594d7a0d1a1505ee0dc.

Powered by Google App Engine
This is Rietveld 408576698