Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(748)

Issue 2466413009: Propagate view background color when changing visible web contents. (Closed)

Created:
4 years, 1 month ago by chrishtr
Modified:
4 years, 1 month ago
Reviewers:
clamy, Peter Kasting, nasko
CC:
chromium-reviews, danakj+watch_chromium.org, darin-cc_chromium.org, jam, jbauman+watch_chromium.org, kalyank, nona+watch_chromium.org, piman+watch_chromium.org, shuchen+watch_chromium.org, James Su, yusukes+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Propagate view background color when changing visible web contents. This avoids flashing white when the previous and next web contents are not white. BUG=470669 Committed: https://crrev.com/95e3953182c062c85c8415a8faf018f3e5f91c4e Cr-Commit-Position: refs/heads/master@{#431089}

Patch Set 1 #

Patch Set 2 : none #

Patch Set 3 : none #

Patch Set 4 : none #

Patch Set 5 : none #

Patch Set 6 : none #

Patch Set 7 : none #

Patch Set 8 : none #

Patch Set 9 : none #

Total comments: 7

Patch Set 10 : none #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -0 lines) Patch
M chrome/browser/ui/browser.cc View 1 2 3 4 5 6 7 8 9 1 chunk +12 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 1 2 3 4 5 6 7 8 2 chunks +8 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_base.h View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_base.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 2 3 4 5 6 7 8 9 1 chunk +12 lines, -0 lines 0 comments Download
M content/public/browser/render_widget_host_view.h View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 38 (24 generated)
chrishtr
4 years, 1 month ago (2016-11-07 19:20:30 UTC) #13
Peter Kasting
You added multiple reviewers; what would you like each to look at?
4 years, 1 month ago (2016-11-07 19:22:42 UTC) #14
chrishtr
Yes, please. Also, I need your approval for chrome/browser/ui specifically. Thanks!
4 years, 1 month ago (2016-11-07 19:24:15 UTC) #15
chrishtr
On 2016/11/07 at 19:24:15, chrishtr wrote: > Yes, please. Also, I need your approval for ...
4 years, 1 month ago (2016-11-07 19:25:11 UTC) #16
Peter Kasting
On 2016/11/07 19:24:15, chrishtr wrote: > Yes, please. I don't know how to parse that ...
4 years, 1 month ago (2016-11-07 19:27:41 UTC) #17
clamy
+nasko since I'm not very familiar with the code and want to make sure it ...
4 years, 1 month ago (2016-11-09 15:56:35 UTC) #22
chrishtr
On 2016/11/09 at 15:56:35, clamy wrote: > +nasko since I'm not very familiar with the ...
4 years, 1 month ago (2016-11-09 18:37:55 UTC) #23
nasko
https://codereview.chromium.org/2466413009/diff/160001/content/browser/web_contents/web_contents_impl.cc File content/browser/web_contents/web_contents_impl.cc (right): https://codereview.chromium.org/2466413009/diff/160001/content/browser/web_contents/web_contents_impl.cc#newcode3959 content/browser/web_contents/web_contents_impl.cc:3959: RenderWidgetHostView* new_view = new_host->GetWidget()->GetView(); I would put this code ...
4 years, 1 month ago (2016-11-09 20:18:58 UTC) #24
chrishtr
https://codereview.chromium.org/2466413009/diff/160001/chrome/browser/ui/browser.cc File chrome/browser/ui/browser.cc (right): https://codereview.chromium.org/2466413009/diff/160001/chrome/browser/ui/browser.cc#newcode1003 chrome/browser/ui/browser.cc:1003: void CopyBackgroundColor(WebContents* old_contents, WebContents* new_contents) { On 2016/11/07 at ...
4 years, 1 month ago (2016-11-09 21:39:36 UTC) #25
chrishtr
https://codereview.chromium.org/2466413009/diff/160001/content/browser/web_contents/web_contents_impl.cc File content/browser/web_contents/web_contents_impl.cc (right): https://codereview.chromium.org/2466413009/diff/160001/content/browser/web_contents/web_contents_impl.cc#newcode3959 content/browser/web_contents/web_contents_impl.cc:3959: RenderWidgetHostView* new_view = new_host->GetWidget()->GetView(); On 2016/11/09 at 20:18:58, nasko ...
4 years, 1 month ago (2016-11-09 21:45:21 UTC) #26
nasko
content/ LGTM
4 years, 1 month ago (2016-11-09 23:55:21 UTC) #31
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2466413009/180001
4 years, 1 month ago (2016-11-09 23:59:23 UTC) #34
commit-bot: I haz the power
Committed patchset #10 (id:180001)
4 years, 1 month ago (2016-11-10 00:05:55 UTC) #36
commit-bot: I haz the power
4 years, 1 month ago (2016-11-10 00:20:17 UTC) #38
Message was sent while issue was closed.
Patchset 10 (id:??) landed as
https://crrev.com/95e3953182c062c85c8415a8faf018f3e5f91c4e
Cr-Commit-Position: refs/heads/master@{#431089}

Powered by Google App Engine
This is Rietveld 408576698