[InputEvent] Support 'insertFromYank' for macOS

[InputEvent] Support 'insertFromYank' for macOS

Yank are macOS specific feature and we need to dispatch InputEvent for it.

Please see bug for more info about yank.

BUG=652401
Review-Url: https://codereview.chromium.org/2738953003
Cr-Commit-Position: refs/heads/master@{#456322}
Committed: https://chromium.googlesource.com/chromium/src/+/f6c436401f1cb45525882a95950af68f6a1203ee

[chongz, 2017-03-08 22:38:56]

The CQ bit was checked by chongz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-08 22:39:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-08 22:43:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-08 22:43:08]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[chongz, 2017-03-08 22:58:55]

The CQ bit was checked by chongz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-08 22:59:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[chongz, 2017-03-08 22:59:33]

Patchset #1 (id:1) has been deleted

[chongz, 2017-03-08 23:00:07]

Description was changed from

==========
Support yank and transpose

BUG=652401
==========

to

==========
[InputEvent] Support 'insertFromYank' and 'insertTranspose' for macOS

BUG=652401
==========

[chongz, 2017-03-08 23:01:24]

Description was changed from

==========
[InputEvent] Support 'insertFromYank' and 'insertTranspose' for macOS

BUG=652401
==========

to

==========
[InputEvent] Support 'insertFromYank' and 'insertTranspose' for macOS

Yank and transpose are macOS specific features, and we need to dispatch
InputEvent
for them.

Please see bug for more info about yank and transpose.

BUG=652401
==========

[chongz, 2017-03-08 23:04:48]

The CQ bit was checked by chongz@chromium.org to run a CQ dry run

[chongz, 2017-03-08 23:05:01]

Patchset #1 (id:20001) has been deleted

[commit-bot: I haz the power, 2017-03-08 23:05:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-09 01:13:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-09 01:13:52]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[chongz, 2017-03-09 02:08:06]

chongz@chromium.org changed reviewers:
+ yosin@chromium.org

[chongz, 2017-03-09 02:08:06]

yosin@ PTAL, thanks!

[yosin_UTC9, 2017-03-09 03:49:11]

Please split this CL into two: one for "Yank" and another for "Transpose" to
make CL smaller since they are exclusive.

https://codereview.chromium.org/2738953003/diff/40001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/NeverFixTests (right):

https://codereview.chromium.org/2738953003/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/NeverFixTests:31: [ Win Linux ]
fast/events/inputevents/inputevent-yank-transpose.html [ WontFix ]
Can we execute "yank" and "transpose" on non-Mac platform?
Do we enable "yank" and "transpose" only for MacOS?

https://codereview.chromium.org/2738953003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/editing/Editor.cpp (right):

https://codereview.chromium.org/2738953003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/Editor.cpp:1421: // TODO(xiaochengh): The
use of updateStyleAndLayoutIgnorePendingStylesheets
nit: s/xiaochengh/editing-dev/

https://codereview.chromium.org/2738953003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp (right):

https://codereview.chromium.org/2738953003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp:1819: //
TODO(xiaochengh): The use of updateStyleAndLayoutIgnorePendingStylesheets
nit: s/xiaochengh/editing-dev/

https://codereview.chromium.org/2738953003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp:1844: //
TODO(xiaochengh): The use of updateStyleAndLayoutIgnorePendingStylesheets
nit: s/xiaochengh/editing-dev/

[chongz, 2017-03-09 16:44:29]

The CQ bit was checked by chongz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-09 16:44:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[chongz, 2017-03-09 16:45:12]

Description was changed from

==========
[InputEvent] Support 'insertFromYank' and 'insertTranspose' for macOS

Yank and transpose are macOS specific features, and we need to dispatch
InputEvent
for them.

Please see bug for more info about yank and transpose.

BUG=652401
==========

to

==========
[InputEvent] Support 'insertFromYank' for macOS

Yank are macOS specific feature and we need to dispatch InputEvent for it.

Please see bug for more info about yank.

BUG=652401
==========

[commit-bot: I haz the power, 2017-03-09 18:37:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-09 18:37:09]

Dry run: This issue passed the CQ dry run.

[chongz, 2017-03-09 21:31:37]

yosin@ I've updated this CL to only include "yank". PATL, thanks!

https://codereview.chromium.org/2738953003/diff/40001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/NeverFixTests (right):

https://codereview.chromium.org/2738953003/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/NeverFixTests:31: [ Win Linux ]
fast/events/inputevents/inputevent-yank-transpose.html [ WontFix ]
On 2017/03/09 03:49:11, yosin_UTC9 wrote:
> Can we execute "yank" and "transpose" on non-Mac platform?
> Do we enable "yank" and "transpose" only for MacOS?

It seems that we don't have "yank" implementation on other platforms. See
"KillRingNone.cpp
":
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/platform/KillR...

And "KillRingMac.mm":
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/platform/mac/K...

"transpose" should work on other platforms, will do it in another patch.

https://codereview.chromium.org/2738953003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/editing/Editor.cpp (right):

https://codereview.chromium.org/2738953003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/Editor.cpp:1421: // TODO(xiaochengh): The
use of updateStyleAndLayoutIgnorePendingStylesheets
On 2017/03/09 03:49:11, yosin_UTC9 wrote:
> nit: s/xiaochengh/editing-dev/

Done.

https://codereview.chromium.org/2738953003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp (right):

https://codereview.chromium.org/2738953003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp:1819: //
TODO(xiaochengh): The use of updateStyleAndLayoutIgnorePendingStylesheets
On 2017/03/09 03:49:11, yosin_UTC9 wrote:
> nit: s/xiaochengh/editing-dev/

Done.

https://codereview.chromium.org/2738953003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp:1844: //
TODO(xiaochengh): The use of updateStyleAndLayoutIgnorePendingStylesheets
On 2017/03/09 03:49:11, yosin_UTC9 wrote:
> nit: s/xiaochengh/editing-dev/

Done.

[yosin_UTC9, 2017-03-10 01:20:06]

yosin@chromium.org changed reviewers:
+ tkent@chromium.org

[yosin_UTC9, 2017-03-10 01:20:07]

lgtm

Thanks for explanation about kill ring.

+tkent@ for core/events/ trivial change

[tkent, 2017-03-10 01:29:15]

lgtm

[chongz, 2017-03-13 00:45:25]

The CQ bit was checked by chongz@chromium.org

[commit-bot: I haz the power, 2017-03-13 00:45:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-13 05:23:40]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1489365925374810,
"parent_rev": "eb7ffe6561358b82498f885544ffdf50a5e46646", "commit_rev":
"f6c436401f1cb45525882a95950af68f6a1203ee"}

[commit-bot: I haz the power, 2017-03-13 05:25:08]

Description was changed from

==========
[InputEvent] Support 'insertFromYank' for macOS

Yank are macOS specific feature and we need to dispatch InputEvent for it.

Please see bug for more info about yank.

BUG=652401
==========

to

==========
[InputEvent] Support 'insertFromYank' for macOS

Yank are macOS specific feature and we need to dispatch InputEvent for it.

Please see bug for more info about yank.

BUG=652401

Review-Url: https://codereview.chromium.org/2738953003
Cr-Commit-Position: refs/heads/master@{#456322}
Committed:
https://chromium.googlesource.com/chromium/src/+/f6c436401f1cb45525882a95950a...
==========

[commit-bot: I haz the power, 2017-03-13 05:25:09]

Committed patchset #2 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/f6c436401f1cb45525882a95950a...