[InputEvent] Support 'insertFromYank' for macOS

third_party/WebKit/Source/core/editing/Editor.cpp

 /*
  * Copyright (C) 2006, 2007, 2008, 2011 Apple Inc. All rights reserved.
  * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 1010 matching lines @@
   m_shouldStyleWithCSS = false;
   m_defaultParagraphSeparator = EditorParagraphSeparatorIsDiv;
   m_lastEditCommand = nullptr;
   m_undoStack->clear();
 }
 
 bool Editor::insertText(const String& text, KeyboardEvent* triggeringEvent) {
   return frame().eventHandler().handleTextInputEvent(text, triggeringEvent);
 }
 
-bool Editor::insertTextWithoutSendingTextEvent(const String& text,
-                                               bool selectInsertedText,
-                                               TextEvent* triggeringEvent) {
+bool Editor::insertTextWithoutSendingTextEvent(
+    const String& text,
+    bool selectInsertedText,
+    TextEvent* triggeringEvent,
+    InputEvent::InputType inputType) {
   if (text.isEmpty())
     return false;
 
   const VisibleSelection& selection = selectionForCommand(triggeringEvent);
   if (!selection.isContentEditable())
     return false;
 
   spellChecker().updateMarkersForWordsAffectedByEditing(
       isSpaceOrNewline(text[0]));
 
   // Insert the text
   TypingCommand::insertText(
       *selection.start().document(), text, selection.asSelection(),
       selectInsertedText ? TypingCommand::SelectInsertedText : 0,
       triggeringEvent && triggeringEvent->isComposition()
           ? TypingCommand::TextCompositionConfirm
-          : TypingCommand::TextCompositionNone);
+          : TypingCommand::TextCompositionNone,
+      false, inputType);
 
   // Reveal the current selection
   if (LocalFrame* editedFrame = selection.start().document()->frame()) {
     if (Page* page = editedFrame->page()) {
       LocalFrame* focusedOrMainFrame =
           toLocalFrame(page->focusController().focusedOrMainFrame());
       focusedOrMainFrame->selection().revealSelection(
           ScrollAlignment::alignCenterIfNeeded);
     }
   }
@@ skipping 337 matching lines @@
   String text = plainText(range);
   if (text.length() != 2)
     return;
   String transposed = text.right(1) + text.left(1);
 
   // Select the two characters.
   if (createVisibleSelection(newSelection) !=
       frame().selection().computeVisibleSelectionInDOMTreeDeprecated())
     frame().selection().setSelection(newSelection);
 
+  if (dispatchBeforeInputInsertText(
+          eventTargetNodeForDocument(frame().document()), transposed,
+          InputEvent::InputType::InsertTranspose) !=
+      DispatchEventResult::NotCanceled)
+    return;
+
+  // 'beforeinput' event handler may destroy document.
+  if (m_frame->document()->frame() != m_frame)
+    return;
+
+  // TODO(xiaochengh): The use of updateStyleAndLayoutIgnorePendingStylesheets

[yosin_UTC9, 2017/03/09 03:49:11]

nit: s/xiaochengh/editing-dev/

[chongz, 2017/03/09 21:31:36]

Done.

+  // needs to be audited. see http://crbug.com/590369 for more details.
+  frame().document()->updateStyleAndLayoutIgnorePendingStylesheets();
+
   // Insert the transposed characters.
-  // TODO(chongz): Once we add |InsertTranspose| in |InputEvent::InputType|, we
-  // should use it instead of |InsertFromPaste|.
   replaceSelectionWithText(transposed, false, false,
-                           InputEvent::InputType::InsertFromPaste);
+                           InputEvent::InputType::InsertTranspose);
 }
 
 void Editor::addToKillRing(const EphemeralRange& range) {
   if (m_shouldStartNewKillRingSequence)
     killRing().startNewSequence();
 
   DCHECK(!frame().document()->needsLayoutTreeUpdate());
   String text = plainText(range);
   killRing().append(text);
   m_shouldStartNewKillRingSequence = false;
@@ skipping 353 matching lines @@
 
 DEFINE_TRACE(Editor) {
   visitor->trace(m_frame);
   visitor->trace(m_lastEditCommand);
   visitor->trace(m_undoStack);
   visitor->trace(m_mark);
   visitor->trace(m_typingStyle);
 }
 
 }  // namespace blink