Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(481)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 273893002: New Layout Test to verify 'float' and 'clear' don't affect grid's items. (Closed)

Created:
6 years, 7 months ago by jfernandez
Modified:
6 years, 6 months ago
CC:
blink-reviews, svillar, jfernandez, Manuel Rego
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

New Layout Test to verify 'float' and 'cleat' don't affect grid's items. BUG=79180 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174931

Patch Set 1 #

Total comments: 1

Patch Set 2 : Applied suggested changes. #

Total comments: 8

Patch Set 3 : Applied suggested changes. #

Patch Set 4 : Using a text test, instead of a ref test. #

Total comments: 2

Patch Set 5 : No need to test float/clear without grid. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -0 lines) Patch
A LayoutTests/fast/css-grid-layout/floating-not-effect-on-grid-items.html View 1 2 3 4 1 chunk +31 lines, -0 lines 0 comments Download
A LayoutTests/fast/css-grid-layout/floating-not-effect-on-grid-items-expected.txt View 1 2 3 4 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
jfernandez
6 years, 7 months ago (2014-05-14 14:42:46 UTC) #1
Manuel Rego
https://codereview.chromium.org/273893002/diff/1/LayoutTests/fast/css-grid-layout/floating-not-effect-on-grid-items.html File LayoutTests/fast/css-grid-layout/floating-not-effect-on-grid-items.html (right): https://codereview.chromium.org/273893002/diff/1/LayoutTests/fast/css-grid-layout/floating-not-effect-on-grid-items.html#newcode19 LayoutTests/fast/css-grid-layout/floating-not-effect-on-grid-items.html:19: <div style="float:left;" class="gridItem firstRowSecondColumn"></div> I'd add 2 items to ...
6 years, 7 months ago (2014-05-14 14:55:35 UTC) #2
jfernandez
6 years, 7 months ago (2014-05-14 16:37:24 UTC) #3
ojan
https://codereview.chromium.org/273893002/diff/20001/LayoutTests/fast/css-grid-layout/floating-not-effect-on-grid-items.html File LayoutTests/fast/css-grid-layout/floating-not-effect-on-grid-items.html (right): https://codereview.chromium.org/273893002/diff/20001/LayoutTests/fast/css-grid-layout/floating-not-effect-on-grid-items.html#newcode2 LayoutTests/fast/css-grid-layout/floating-not-effect-on-grid-items.html:2: <html> We usually leave out the <html><head> and <body> ...
6 years, 7 months ago (2014-05-21 18:40:57 UTC) #4
jfernandez
Applied suggested changes. https://codereview.chromium.org/273893002/diff/20001/LayoutTests/fast/css-grid-layout/floating-not-effect-on-grid-items.html File LayoutTests/fast/css-grid-layout/floating-not-effect-on-grid-items.html (right): https://codereview.chromium.org/273893002/diff/20001/LayoutTests/fast/css-grid-layout/floating-not-effect-on-grid-items.html#newcode2 LayoutTests/fast/css-grid-layout/floating-not-effect-on-grid-items.html:2: <html> On 2014/05/21 18:40:57, ojan wrote: ...
6 years, 7 months ago (2014-05-22 15:16:52 UTC) #5
ojan
https://codereview.chromium.org/273893002/diff/20001/LayoutTests/fast/css-grid-layout/floating-not-effect-on-grid-items.html File LayoutTests/fast/css-grid-layout/floating-not-effect-on-grid-items.html (right): https://codereview.chromium.org/273893002/diff/20001/LayoutTests/fast/css-grid-layout/floating-not-effect-on-grid-items.html#newcode18 LayoutTests/fast/css-grid-layout/floating-not-effect-on-grid-items.html:18: <div style="float: right;" class="gridItem firstRowFirstColumn"></div> On 2014/05/22 15:16:52, jfernandez ...
6 years, 7 months ago (2014-05-23 02:13:36 UTC) #6
jfernandez
https://codereview.chromium.org/273893002/diff/20001/LayoutTests/fast/css-grid-layout/floating-not-effect-on-grid-items.html File LayoutTests/fast/css-grid-layout/floating-not-effect-on-grid-items.html (right): https://codereview.chromium.org/273893002/diff/20001/LayoutTests/fast/css-grid-layout/floating-not-effect-on-grid-items.html#newcode18 LayoutTests/fast/css-grid-layout/floating-not-effect-on-grid-items.html:18: <div style="float: right;" class="gridItem firstRowFirstColumn"></div> On 2014/05/23 02:13:36, ojan ...
6 years, 7 months ago (2014-05-23 14:57:06 UTC) #7
ojan
https://codereview.chromium.org/273893002/diff/60001/LayoutTests/fast/css-grid-layout/floating-not-effect-on-grid-items.html File LayoutTests/fast/css-grid-layout/floating-not-effect-on-grid-items.html (right): https://codereview.chromium.org/273893002/diff/60001/LayoutTests/fast/css-grid-layout/floating-not-effect-on-grid-items.html#newcode30 LayoutTests/fast/css-grid-layout/floating-not-effect-on-grid-items.html:30: <p>This layout shows where the float blocks would be ...
6 years, 7 months ago (2014-05-23 19:56:59 UTC) #8
jfernandez
Applied suggested changes in the last patch. https://codereview.chromium.org/273893002/diff/60001/LayoutTests/fast/css-grid-layout/floating-not-effect-on-grid-items.html File LayoutTests/fast/css-grid-layout/floating-not-effect-on-grid-items.html (right): https://codereview.chromium.org/273893002/diff/60001/LayoutTests/fast/css-grid-layout/floating-not-effect-on-grid-items.html#newcode30 LayoutTests/fast/css-grid-layout/floating-not-effect-on-grid-items.html:30: <p>This layout ...
6 years, 7 months ago (2014-05-26 09:18:39 UTC) #9
ojan
lgtm
6 years, 7 months ago (2014-05-28 02:33:29 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jfernandez@igalia.com/273893002/80001
6 years, 7 months ago (2014-05-28 02:34:14 UTC) #11
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 6 months ago (2014-05-28 04:07:05 UTC) #12
commit-bot: I haz the power
6 years, 6 months ago (2014-05-28 05:22:35 UTC) #13
Message was sent while issue was closed. 
Change committed as 174931

Powered by Google App Engine
This is Rietveld 408576698