LayoutTests/fast/css-grid-layout/floating-not-effect-on-grid-items.html - Issue 273893002: New Layout Test to verify 'float' and 'clear' don't affect grid's items.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/css-grid-layout/floating-not-effect-on-grid-items.html

Issue 273893002: New Layout Test to verify 'float' and 'clear' don't affect grid's items. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <link href="resources/grid.css" rel="stylesheet">

	4 <head>

	5 <style>

	6 .grid {

	7 background-color:grey;

	8 }

	9 .gridItem {

	10 width: 50px;

	11 height: 50px;

	12 }

	13 </style>

	14 </head>

	15 <body>

	16 <div>This test checks that the grid's items are not affected by the 'float' and 'clear' properties.</div>

	17 <div class="grid">

	18 <div style="float:right;" class="gridItem firstRowFirstColumn"></div>

	19 <div style="float:left;" class="gridItem firstRowSecondColumn"></div>
	Manuel Rego 2014/05/14 14:55:36 I'd add 2 items to the same grid cell to check tha I'd add 2 items to the same grid cell to check that floating is not doing anything there. For example something like: <div style="float: left;" class="gridItem firstRowFirstColumn"></div> <div class="gridItem firstRowFirstColumn"></div> BTW, you're not testing "clear" so you can add a test for it or remove it from the description I guess.
	20 <div style="float:right;" class="gridItem secondRowFirstColumn"></div>

	21 <div style="float:left;" class="gridItem secondRowSecondColumn"></div>

	22 </div>

	23 </body>

	24 </html>

	25

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/fast/css-grid-layout/floating-not-effect-on-grid-items-expected.html » ('j') | no next file with comments »