LayoutTests/fast/css-grid-layout/floating-not-effect-on-grid-items.html - Issue 273893002: New Layout Test to verify 'float' and 'clear' don't affect grid's items.

Side by Side Diff: LayoutTests/fast/css-grid-layout/floating-not-effect-on-grid-items.html

Issue 273893002: New Layout Test to verify 'float' and 'clear' don't affect grid's items. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Using a text test, instead of a ref test. Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <link href="resources/grid.css" rel="stylesheet">

	4 <script src="../../resources/check-layout.js"></script>

	5 <style>

	6 .container {

	7 background-color:grey;

	8 }

	9

	10 .gridItem {

	11 width: 50px;

	12 height: 50px;

	13 }

	14 </style>

	15 <body onload="checkLayout('.container')">

	16

	17 <p>This test checks that the grid's items are not affected by the 'float' and 'c lear' properties.</p>

	18

	19 <div style="position: relative">

	20 <div class="container grid">

	21 <div style="float: right;" class="gridItem firstRowFirstColumn" data-off set-x="0" data-offset-y="0" data-expected-width="50" data-expected-height="50">< /div>

	22 <div class="gridItem firstRowFirstColumn" data-offset-x="0" data-offset- y="0" data-expected-width="50" data-expected-height="50"></div>

	23 <div style="float: left;" class="gridItem firstRowSecondColumn" data-off set-x="50" data-offset-y="0" data-expected-width="50" data-expected-height="50"> </div>

	24 <div style="float: left;" class="gridItem secondRowFirstColumn" data-off set-x="0" data-offset-y="50" data-expected-width="50" data-expected-height="50"> </div>

	25 <div style="clear: both;" class="gridItem secondRowFirstColumn" data-off set-x="0" data-offset-y="50" data-expected-width="50" data-expected-height="50"> </div>

	26 <div style="float: left;" class="gridItem secondRowSecondColumn" data-of fset-x="50" data-offset-y="50" data-expected-width="50" data-expected-height="50 "></div>

	27 </div>

	28 </div>

	29

	30 <p>This layout shows where the float blocks would be positioned without the grid .</p>
	ojan 2014/05/23 19:56:59 What's the value of testing the positioning withou What's the value of testing the positioning without the grid? We already have test coverage for float:left/right and for clear:both on non-grids. jfernandez 2014/05/26 09:18:39 Yeah, you're totally right. I thought it would hel Show quoted text On 2014/05/23 19:56:59, ojan wrote: > What's the value of testing the positioning without the grid? We already have > test coverage for float:left/right and for clear:both on non-grids. Yeah, you're totally right. I thought it would help to clarify the purpose of the test but it just adds noise. Done.
	31

	32 <div style="position: relative">

	33 <div style="height: 200px; width: 400px;" class="container">

	34 <div style="float: right;" class="gridItem firstRowFirstColumn" data-off set-x="350" data-offset-y="0" data-expected-width="50" data-expected-height="50" ></div>

	35 <div class="gridItem firstRowFirstColumn" data-offset-x="0" data-offset- y="0" data-expected-width="50" data-expected-height="50"></div>

	36 <div style="float: left;" class="gridItem firstRowSecondColumn" data-off set-x="0" data-offset-y="50" data-expected-width="50" data-expected-height="50"> </div>

	37 <div style="float: left;" class="gridItem secondRowFirstColumn" data-off set-x="50" data-offset-y="50" data-expected-width="50" data-expected-height="50" ></div>

	38 <div style="clear: both;" class="gridItem secondRowFirstColumn" data-off set-x="0" data-offset-y="100" data-expected-width="50" data-expected-height="50" ></div>

	39 <div style="float: left;" class="gridItem secondRowSecondColumn" data-of fset-x="0" data-offset-y="150" data-expected-width="50" data-expected-height="50 "></div>

	40 </div>

	41 </div>

	42

	43 </body>

	44 </html>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/fast/css-grid-layout/floating-not-effect-on-grid-items-expected.txt » ('j') | no next file with comments »