third_party/WebKit/Source/core/svg/graphics/filters/SVGFilterBuilder.h - Issue 2738863002: Replace ASSERT with DCHECK in core/svg/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/svg/graphics/filters/SVGFilterBuilder.h

Issue 2738863002: Replace ASSERT with DCHECK in core/svg/ (Closed)

Patch Set: Split DCHECKS wherever possible Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/svg/graphics/SVGImage.cpp ('k') | third_party/WebKit/Source/core/svg/graphics/filters/SVGFilterBuilder.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/svg/graphics/filters/SVGFilterBuilder.h

diff --git a/third_party/WebKit/Source/core/svg/graphics/filters/SVGFilterBuilder.h b/third_party/WebKit/Source/core/svg/graphics/filters/SVGFilterBuilder.h

index 62c36fab06c75737485a7e426968d9735df39d64..09bdd31ff4ce3bdf7d3534148fc8d979e2a95ae1 100644

--- a/third_party/WebKit/Source/core/svg/graphics/filters/SVGFilterBuilder.h

+++ b/third_party/WebKit/Source/core/svg/graphics/filters/SVGFilterBuilder.h

@@ -51,7 +51,7 @@ class SVGFilterGraphNodeMap final

inline FilterEffectSet& effectReferences(FilterEffect* effect) {

// Only allowed for effects belongs to this builder.

- ASSERT(m_effectReferences.contains(effect));

+ DCHECK(m_effectReferences.contains(effect));

return m_effectReferences.find(effect)->value;

}