Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(617)

Unified Diff: third_party/WebKit/Source/core/svg/graphics/SVGImage.cpp

Issue 2738863002: Replace ASSERT with DCHECK in core/svg/ (Closed)
Patch Set: Split DCHECKS wherever possible Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/svg/graphics/SVGImage.cpp
diff --git a/third_party/WebKit/Source/core/svg/graphics/SVGImage.cpp b/third_party/WebKit/Source/core/svg/graphics/SVGImage.cpp
index e1e46b64b6caf44e62030d3fcc735ee9dbb35699..9fd2957fab2675479eb44d1f1a3a1e6d44933629 100644
--- a/third_party/WebKit/Source/core/svg/graphics/SVGImage.cpp
+++ b/third_party/WebKit/Source/core/svg/graphics/SVGImage.cpp
@@ -79,11 +79,11 @@ SVGImage::~SVGImage() {
}
// Verify that page teardown destroyed the Chrome
- ASSERT(!m_chromeClient || !m_chromeClient->image());
+ DCHECK(!m_chromeClient || !m_chromeClient->image());
}
bool SVGImage::isInSVGImage(const Node* node) {
- ASSERT(node);
+ DCHECK(node);
Page* page = node->document().page();
if (!page)
@@ -146,7 +146,7 @@ IntSize SVGImage::containerSize() const {
return containerSize;
// Assure that a container size is always given for a non-identity zoom level.
- ASSERT(layoutObject->style()->effectiveZoom() == 1);
+ DCHECK_EQ(layoutObject->style()->effectiveZoom(), 1);
// No set container size; use concrete object size.
return m_intrinsicSize;
@@ -421,7 +421,7 @@ void SVGImage::drawInternal(PaintCanvas* canvas,
view->updateAllLifecyclePhasesExceptPaint();
view->paint(builder.context(), CullRect(enclosingIntRect(srcRect)));
- ASSERT(!view->needsLayout());
+ DCHECK(!view->needsLayout());
}
{

Powered by Google App Engine
This is Rietveld 408576698