third_party/WebKit/Source/core/svg/graphics/filters/SVGFilterBuilder.cpp - Issue 2738863002: Replace ASSERT with DCHECK in core/svg/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/svg/graphics/filters/SVGFilterBuilder.cpp

Issue 2738863002: Replace ASSERT with DCHECK in core/svg/ (Closed)

Patch Set: Split DCHECKS wherever possible Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/svg/graphics/filters/SVGFilterBuilder.h ('k') | third_party/WebKit/Source/core/svg/properties/SVGAnimatedProperty.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/svg/graphics/filters/SVGFilterBuilder.cpp

diff --git a/third_party/WebKit/Source/core/svg/graphics/filters/SVGFilterBuilder.cpp b/third_party/WebKit/Source/core/svg/graphics/filters/SVGFilterBuilder.cpp

index b5fbe5500f70211b6613175840ccaa85459c5235..8a60cddb77b410dd667f26c62525937c7cfab0ae 100644

--- a/third_party/WebKit/Source/core/svg/graphics/filters/SVGFilterBuilder.cpp

+++ b/third_party/WebKit/Source/core/svg/graphics/filters/SVGFilterBuilder.cpp

@@ -70,8 +70,8 @@ void SVGFilterGraphNodeMap::addBuiltinEffect(FilterEffect* effect) {

void SVGFilterGraphNodeMap::addPrimitive(LayoutObject* object,

FilterEffect* effect) {

// The effect must be a newly created filter effect.

- ASSERT(!m_effectReferences.contains(effect));

- ASSERT(!object || !m_effectRenderer.contains(object));

+ DCHECK(!m_effectReferences.contains(effect));

+ DCHECK(!object || !m_effectRenderer.contains(object));

m_effectReferences.insert(effect, FilterEffectSet());

unsigned numberOfInputEffects = effect->inputEffects().size();