third_party/WebKit/Source/core/svg/properties/SVGAnimatedProperty.h - Issue 2738863002: Replace ASSERT with DCHECK in core/svg/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/svg/properties/SVGAnimatedProperty.h

Issue 2738863002: Replace ASSERT with DCHECK in core/svg/ (Closed)

Patch Set: Split DCHECKS wherever possible Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/svg/graphics/filters/SVGFilterBuilder.cpp ('k') | third_party/WebKit/Source/core/svg/properties/SVGListPropertyHelper.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/svg/properties/SVGAnimatedProperty.h

diff --git a/third_party/WebKit/Source/core/svg/properties/SVGAnimatedProperty.h b/third_party/WebKit/Source/core/svg/properties/SVGAnimatedProperty.h

index 35e6ac143ef701aef9e8ac196c355739d2346106..c67a4cb78f9ec14a975626f069be11d54587f254 100644

--- a/third_party/WebKit/Source/core/svg/properties/SVGAnimatedProperty.h

+++ b/third_party/WebKit/Source/core/svg/properties/SVGAnimatedProperty.h

@@ -133,7 +133,7 @@ class SVGAnimatedPropertyCommon : public SVGAnimatedPropertyBase {

}

void setAnimatedValue(SVGPropertyBase* value) override {

- ASSERT(value->type() == Property::classType());

+ DCHECK_EQ(value->type(), Property::classType());

m_currentValue = static_cast<Property*>(value);

}

@@ -195,7 +195,7 @@ class SVGAnimatedProperty : public SVGAnimatedPropertyCommon<Property> {

this->baseValue()->setValue(value);

m_baseValueUpdated = true;

- ASSERT(this->attributeName() != QualifiedName::null());

+ DCHECK(this->attributeName() != QualifiedName::null());

this->contextElement()->invalidateSVGAttributes();

this->contextElement()->svgAttributeBaseValChanged(this->attributeName());

}